You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pu...@apache.org on 2014/11/14 19:34:54 UTC
cordova-plugin-vibration git commit: CB-8018 Add vibrate(pattern)
fallback on vibrate for Windows Phone 8
Repository: cordova-plugin-vibration
Updated Branches:
refs/heads/master a520f0de0 -> 621984529
CB-8018 Add vibrate(pattern) fallback on vibrate for Windows Phone 8
Added vibrate(pattern) fallback on vibrate for Windows Phone 8
Added vibration cancelling support for Windows Phone 8
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-vibration/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-vibration/commit/62198452
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-vibration/tree/62198452
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-vibration/diff/62198452
Branch: refs/heads/master
Commit: 621984529a2ecaa4879012aeef078413742d5797
Parents: a520f0d
Author: daserge <da...@yandex.ru>
Authored: Fri Nov 14 19:30:11 2014 +0300
Committer: daserge <da...@yandex.ru>
Committed: Fri Nov 14 19:30:11 2014 +0300
----------------------------------------------------------------------
doc/index.md | 5 +++++
src/wp/Vibration.cs | 24 ++++++++++++++++++++++--
2 files changed, 27 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-vibration/blob/62198452/doc/index.md
----------------------------------------------------------------------
diff --git a/doc/index.md b/doc/index.md
index af360b9..7bfff54 100755
--- a/doc/index.md
+++ b/doc/index.md
@@ -49,6 +49,7 @@ navigator.notification.vibrate
navigator.notification.vibrateWithPattern,<br />navigator.notification.cancelVibration
- Android
+- Windows Phone 8
## vibrate (recommended)
@@ -103,6 +104,10 @@ Vibrates the device with a given pattern
// Vibrate for 5 seconds
navigator.vibrate([1000, 1000, 3000, 1000, 5000]);
+####Windows Phone 8 Quirks
+
+- vibrate(pattern) falls back on vibrate with default duration
+
###Cancel vibration (not supported in iOS)
Immediately cancels any currently running vibration.
http://git-wip-us.apache.org/repos/asf/cordova-plugin-vibration/blob/62198452/src/wp/Vibration.cs
----------------------------------------------------------------------
diff --git a/src/wp/Vibration.cs b/src/wp/Vibration.cs
index cd58d67..3a122e6 100644
--- a/src/wp/Vibration.cs
+++ b/src/wp/Vibration.cs
@@ -27,11 +27,11 @@ namespace WPCordovaClassLib.Cordova.Commands
{
public class Vibration : BaseCommand
{
+ private static readonly int DEFAULT_DURATION = 200;
public void vibrate(string vibrateDuration)
{
-
- int msecs = 200; // set default
+ int msecs = DEFAULT_DURATION; // set default
try
{
@@ -48,10 +48,30 @@ namespace WPCordovaClassLib.Cordova.Commands
}
+ vibrateMs(msecs);
+
+ // TODO: may need to add listener to trigger DispatchCommandResult when the vibration ends...
+ DispatchCommandResult();
+ }
+
+ private static void vibrateMs(int msecs)
+ {
VibrateController.Default.Start(TimeSpan.FromMilliseconds(msecs));
+ }
+
+ public void vibrateWithPattern(string options)
+ {
+ // falling back to vibrate
+ vibrateMs(DEFAULT_DURATION);
// TODO: may need to add listener to trigger DispatchCommandResult when the vibration ends...
DispatchCommandResult();
}
+
+ public void cancelVibration(string options)
+ {
+ VibrateController.Default.Stop();
+ DispatchCommandResult();
+ }
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org