You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/05 05:57:35 UTC
[GitHub] [shardingsphere] codecov-io edited a comment on pull request #5423: BugFix:1.ON DUPLICATE KEY UPDATE Sub-Clause paramter dropped https:…
codecov-io edited a comment on pull request #5423:
URL: https://github.com/apache/shardingsphere/pull/5423#issuecomment-623858978
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5423?src=pr&el=h1) Report
> Merging [#5423](https://codecov.io/gh/apache/shardingsphere/pull/5423?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3b86c9468725b1db7414d526ef334e4880206637&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `65.68%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5423?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5423 +/- ##
============================================
- Coverage 53.83% 53.68% -0.16%
Complexity 419 419
============================================
Files 1165 1167 +2
Lines 20873 21036 +163
Branches 3769 3805 +36
============================================
+ Hits 11238 11294 +56
- Misses 8919 9019 +100
- Partials 716 723 +7
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5423?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...sql/parser/mysql/visitor/impl/MySQLDMLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/5423/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL2ltcGwvTXlTUUxETUxWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...derlying/rewrite/engine/RouteSQLRewriteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/5423/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1yZXdyaXRlL3NoYXJkaW5nc3BoZXJlLXJld3JpdGUtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS91bmRlcmx5aW5nL3Jld3JpdGUvZW5naW5lL1JvdXRlU1FMUmV3cml0ZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...arameter/builder/impl/GroupedParameterBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/5423/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1yZXdyaXRlL3NoYXJkaW5nc3BoZXJlLXJld3JpdGUtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS91bmRlcmx5aW5nL3Jld3JpdGUvcGFyYW1ldGVyL2J1aWxkZXIvaW1wbC9Hcm91cGVkUGFyYW1ldGVyQnVpbGRlci5qYXZh) | `62.06% <41.17%> (-17.94%)` | `0.00 <0.00> (ø)` | |
| [...r/binder/statement/dml/InsertStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5423/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvc3RhdGVtZW50L2RtbC9JbnNlcnRTdGF0ZW1lbnRDb250ZXh0LmphdmE=) | `65.62% <42.85%> (-20.74%)` | `0.00 <0.00> (ø)` | |
| [...ertOnDuplicateKeyUpdateValueParameterRewriter.java](https://codecov.io/gh/apache/shardingsphere/pull/5423/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvcGFyYW1ldGVyL2ltcGwvRW5jcnlwdEluc2VydE9uRHVwbGljYXRlS2V5VXBkYXRlVmFsdWVQYXJhbWV0ZXJSZXdyaXRlci5qYXZh) | `76.47% <73.91%> (+1.47%)` | `1.00 <0.00> (ø)` | |
| [...egment/insert/values/OnDuplicateUpdateContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5423/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvc2VnbWVudC9pbnNlcnQvdmFsdWVzL09uRHVwbGljYXRlVXBkYXRlQ29udGV4dC5qYXZh) | `78.12% <78.12%> (ø)` | `0.00 <0.00> (?)` | |
| [...ator/impl/EncryptInsertOnUpdateTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/5423/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvRW5jcnlwdEluc2VydE9uVXBkYXRlVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `90.00% <100.00%> (+2.82%)` | `0.00 <0.00> (ø)` | |
| [.../underlying/rewrite/context/SQLRewriteContext.java](https://codecov.io/gh/apache/shardingsphere/pull/5423/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1yZXdyaXRlL3NoYXJkaW5nc3BoZXJlLXJld3JpdGUtZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS91bmRlcmx5aW5nL3Jld3JpdGUvY29udGV4dC9TUUxSZXdyaXRlQ29udGV4dC5qYXZh) | `80.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../orchestration/core/configcenter/ConfigCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/5423/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9Db25maWdDZW50ZXIuamF2YQ==) | `73.03% <0.00%> (-1.97%)` | `0.00% <0.00%> (ø%)` | |
| [...apache/shardingsphere/shardingproxy/Bootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/5423/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3Byb3h5L0Jvb3RzdHJhcC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [16 more](https://codecov.io/gh/apache/shardingsphere/pull/5423/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5423?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5423?src=pr&el=footer). Last update [3b86c94...9bcebb1](https://codecov.io/gh/apache/shardingsphere/pull/5423?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org