You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/23 08:06:16 UTC
[GitHub] [pulsar] holmes07 opened a new pull request #13464: [broker]loadBalancerMemoryResourceWeight config default value optimiz…
holmes07 opened a new pull request #13464:
URL: https://github.com/apache/pulsar/pull/13464
### Motivation
*memory.percentUsage() value is depends on the gc trigger moment, this value has a random affect on ThresholdShedder loadBalancer strategy. it is a meaningless dimension*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- The default values of configurations: (yes)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [ ] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #13464: [broker]loadBalancerMemoryResourceWeight config default value optimiz…
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #13464:
URL: https://github.com/apache/pulsar/pull/13464#issuecomment-1000599968
@holmes07 do you mean this PR does not affect docs? If so, please tick the box, or else Bot can not recognize it and label this PR w/ `doc-info-missing`.
Doc label instructions: https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0/edit#heading=h.2l8eeumd84w0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] holmes07 commented on pull request #13464: [broker]loadBalancerMemoryResourceWeight config default value optimiz…
Posted by GitBox <gi...@apache.org>.
holmes07 commented on pull request #13464:
URL: https://github.com/apache/pulsar/pull/13464#issuecomment-1000228219
> @holmes07 To change the default value of the broker should be discussed in the dev email list first, here is an example https://lists.apache.org/thread/t5ylgvcsp11of7lvw7cbf69f5qlpj8ob, do you want to send an email to the dev email list?
1 will handle it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] holmes07 commented on pull request #13464: [broker]loadBalancerMemoryResourceWeight config default value optimiz…
Posted by GitBox <gi...@apache.org>.
holmes07 commented on pull request #13464:
URL: https://github.com/apache/pulsar/pull/13464#issuecomment-1000692148
> We'd better decrease the weight but should be bigger than 0. Because it can reflect the heap usage.
###
**some gc detail on my case, it happens about every 10s(this may be relevant to -XX:MaxGCPauseMillis=500) ，only about 25% memory usage survivors(maybe 0.25 is one option value). But as eden space is not a stable zone , the memory usage is depends on both the load report moment and the gc trigger moment . if the default loadBalancerHistoryResourcePercentage = 0.9 decrease to a more sensitivity value, it may has higher chance to cause some traffic flow from one broker to other broker frequently . i think maybe cpu &network& directMemory is enough to refect the real traffic**
[Eden: 9816.0M(9816.0M)->0.0B(9816.0M) Survivors: 8192.0K->8192.0K Heap: 13.4G(16.0G)->3954.4M(16.0G)]
[Eden: 9816.0M(9816.0M)->0.0B(9816.0M) Survivors: 8192.0K->8192.0K Heap: 13.4G(16.0G)->3954.4M(16.0G)]
[Eden: 9816.0M(9816.0M)->0.0B(9816.0M) Survivors: 8192.0K->8192.0K Heap: 13.4G(16.0G)->3954.8M(16.0G)]
[Eden: 9816.0M(9816.0M)->0.0B(9816.0M) Survivors: 8192.0K->8192.0K Heap: 13.4G(16.0G)->3954.6M(16.0G)]
[Eden: 9816.0M(9816.0M)->0.0B(9816.0M) Survivors: 8192.0K->8192.0K Heap: 13.4G(16.0G)->3955.1M(16.0G)]
[Eden: 9816.0M(9816.0M)->0.0B(9816.0M) Survivors: 8192.0K->8192.0K Heap: 13.4G(16.0G)->3955.0M(16.0G)]
[Eden: 9816.0M(9816.0M)->0.0B(9816.0M) Survivors: 8192.0K->8192.0K Heap: 13.4G(16.0G)->3955.4M(16.0G)]
[Eden: 9816.0M(9816.0M)->0.0B(9816.0M) Survivors: 8192.0K->8192.0K Heap: 13.4G(16.0G)->3955.4M(16.0G)]
[Eden: 9816.0M(9816.0M)->0.0B(9816.0M) Survivors: 8192.0K->8192.0K Heap: 13.4G(16.0G)->3955.8M(16.0G)]
[Eden: 9816.0M(9816.0M)->0.0B(9816.0M) Survivors: 8192.0K->8192.0K Heap: 13.4G(16.0G)->3956.1M(16.0G)]
[Eden: 9816.0M(9816.0M)->0.0B(9816.0M) Survivors: 8192.0K->8192.0K Heap: 13.4G(16.0G)->3957.3M(16.0G)]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #13464: [broker]loadBalancerMemoryResourceWeight config default value optimiz…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13464:
URL: https://github.com/apache/pulsar/pull/13464#issuecomment-1051438193
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #13464: [broker]loadBalancerMemoryResourceWeight config default value optimiz…
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #13464:
URL: https://github.com/apache/pulsar/pull/13464#issuecomment-1000197697
@holmes07 To change the default value of the broker should be discussed in the dev email list first, here is an example https://lists.apache.org/thread/t5ylgvcsp11of7lvw7cbf69f5qlpj8ob, do you want to send an email to the dev email list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #13464: [broker]loadBalancerMemoryResourceWeight config default value optimiz…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13464:
URL: https://github.com/apache/pulsar/pull/13464#issuecomment-1000118015
@holmes07:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #13464: [broker]loadBalancerMemoryResourceWeight config default value optimiz…
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #13464:
URL: https://github.com/apache/pulsar/pull/13464#issuecomment-1000660771
We'd better decrease the weight but should be bigger than 0. Because it can reflect the heap usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org