You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/19 19:29:52 UTC
[GitHub] [superset] suddjian opened a new issue #17328: SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default
suddjian opened a new issue #17328:
URL: https://github.com/apache/superset/issues/17328
Should we apply and remove the `DASHBOARD_NATIVE_FILTER` flag in [Superset 2.0](https://github.com/apache/superset/issues/17081)? Or maybe we should keep the flag but just turn it on by default?
What's required:
- A filter box migration script
- Sufficiently high feature quality (I'm not sure what current status is here, maybe someone can catch me up)
Do we want to apply the same treatment to the other related feature flags too? What additional prep might be necessary for them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #17328: SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #17328:
URL: https://github.com/apache/superset/issues/17328#issuecomment-966856593
we already turned said feature flag on by default 😅 and had a discussion to keep the FF until re reach 120% feature parity, which is current missing some complex use case of multiple filter boxes being a group of filters that limit filter value of each other. filter box code and the FF will both be removed after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #17328: SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #17328:
URL: https://github.com/apache/superset/issues/17328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on issue #17328: SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default
Posted by GitBox <gi...@apache.org>.
suddjian commented on issue #17328:
URL: https://github.com/apache/superset/issues/17328#issuecomment-974351878
@junlincc Are there any issues or trackable things for that functionality, that we can link to from this issue? If that work gets done before SIP-74 is finalized, then it sounds like removing the flag would be a good addition to 2.0. Otherwise it would be best left for a later major release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian edited a comment on issue #17328: SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default
Posted by GitBox <gi...@apache.org>.
suddjian edited a comment on issue #17328:
URL: https://github.com/apache/superset/issues/17328#issuecomment-974351878
@junlincc Are there any issues or trackable things for that functionality, that we can link to from this issue? If that work gets done before SIP-74 is finalized, then removing the flag would be a good addition. Otherwise it would be best left for a later major release. Linking to it from here will make it easier to do 2.0 planning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] tweinreich commented on issue #17328: SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default
Posted by GitBox <gi...@apache.org>.
tweinreich commented on issue #17328:
URL: https://github.com/apache/superset/issues/17328#issuecomment-961503173
I think it would be great if features like `DASHBOARD_NATIVE_FILTER` would be enabled by default but still exist as flags (_or admin menu options_) to turn them off. In my opinion the experience of creating filters is much easier compared to using the filter box chart widget and jinja templating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian edited a comment on issue #17328: SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default
Posted by GitBox <gi...@apache.org>.
suddjian edited a comment on issue #17328:
URL: https://github.com/apache/superset/issues/17328#issuecomment-974351878
@junlincc If that work gets done before SIP-74 is finalized (which might be quite a while), then removing the flag would be a good addition. Otherwise it would be best left for a later major release.
Are there any issues or trackable things for that functionality, that we can link to from this issue? Linking to it from here will make it easier to do 2.0 planning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] tweinreich commented on issue #17328: SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default
Posted by GitBox <gi...@apache.org>.
tweinreich commented on issue #17328:
URL: https://github.com/apache/superset/issues/17328#issuecomment-961503173
I think it would be great if features like `DASHBOARD_NATIVE_FILTER` would be enabled by default but still exist as flags (_or admin menu options_) to turn them off. In my opinion the experience of creating filters is much easier compared to using the filter box chart widget and jinja templating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian edited a comment on issue #17328: SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default
Posted by GitBox <gi...@apache.org>.
suddjian edited a comment on issue #17328:
URL: https://github.com/apache/superset/issues/17328#issuecomment-974351878
@junlincc Are there any issues or trackable things for that functionality, that we can link to from this issue? If that work gets done before SIP-74 is finalized (which might be quite a while), then removing the flag would be a good addition. Otherwise it would be best left for a later major release. Linking to it from here will make it easier to do 2.0 planning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] tweinreich commented on issue #17328: SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default
Posted by GitBox <gi...@apache.org>.
tweinreich commented on issue #17328:
URL: https://github.com/apache/superset/issues/17328#issuecomment-961503173
I think it would be great if features like `DASHBOARD_NATIVE_FILTER` would be enabled by default but still exist as flags (_or admin menu options_) to turn them off. In my opinion the experience of creating filters is much easier compared to using the filter box chart widget and jinja templating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian closed issue #17328: SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default
Posted by GitBox <gi...@apache.org>.
suddjian closed issue #17328:
URL: https://github.com/apache/superset/issues/17328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on issue #17328: SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default
Posted by GitBox <gi...@apache.org>.
suddjian commented on issue #17328:
URL: https://github.com/apache/superset/issues/17328#issuecomment-1035244113
This was done apparently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian edited a comment on issue #17328: SIP-74 sub-proposal: Turn on DASHBOARD_NATIVE_FILTERS feature flag by default
Posted by GitBox <gi...@apache.org>.
suddjian edited a comment on issue #17328:
URL: https://github.com/apache/superset/issues/17328#issuecomment-974351878
@junlincc Are there any issues or trackable things for that functionality, that we can link to from this issue? If that work gets done before SIP-74 is finalized, then it sounds like removing the flag would be a good addition to 2.0. Otherwise it would be best left for a later major release. Linking to it from here will make it easier to do 2.0 planning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org