You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by jo...@apache.org on 2016/02/12 20:29:47 UTC

[1/2] git commit: [flex-asjs] [refs/heads/develop] - trace(): better detection of window.console() so that there isn't a runtime error in a Node.js release build

Repository: flex-asjs
Updated Branches:
  refs/heads/develop 8156e98b3 -> 59b8e43f7


trace(): better detection of window.console() so that there isn't a runtime error in a Node.js release build


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/9afa2c11
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/9afa2c11
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/9afa2c11

Branch: refs/heads/develop
Commit: 9afa2c111e92953c94c9adab10540890252a1f49
Parents: 8156e98
Author: Josh Tynjala <jo...@apache.org>
Authored: Fri Feb 12 11:07:27 2016 -0800
Committer: Josh Tynjala <jo...@apache.org>
Committed: Fri Feb 12 11:07:27 2016 -0800

----------------------------------------------------------------------
 .../Core/src/main/flex/org/apache/flex/utils/Language.as        | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/9afa2c11/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/Language.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/Language.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/Language.as
index 6a26191..e3a318c 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/Language.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/Language.as
@@ -308,10 +308,9 @@ package org.apache.flex.utils
 
 			if (theConsole === undefined)
 			{
-            	var windowConsole:* = window.console;
-				if (windowConsole !== undefined)
+				if(typeof window !== "undefined")
 				{
-					theConsole = windowConsole;
+					theConsole = window.console;
 				}
 			}
 


[2/2] git commit: [flex-asjs] [refs/heads/develop] - Core: Language now checks for global console variable as final fallback, which adds trace() support for Node.js release builds

Posted by jo...@apache.org.
Core: Language now checks for global console variable as final fallback, which adds trace() support for Node.js release builds


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/59b8e43f
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/59b8e43f
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/59b8e43f

Branch: refs/heads/develop
Commit: 59b8e43f7e1edad135f77518127f8f3fa51cd6e6
Parents: 9afa2c1
Author: Josh Tynjala <jo...@apache.org>
Authored: Fri Feb 12 11:29:26 2016 -0800
Committer: Josh Tynjala <jo...@apache.org>
Committed: Fri Feb 12 11:29:26 2016 -0800

----------------------------------------------------------------------
 .../Core/src/main/flex/org/apache/flex/utils/Language.as         | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/59b8e43f/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/Language.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/Language.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/Language.as
index e3a318c..2586e77 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/Language.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/Language.as
@@ -312,6 +312,10 @@ package org.apache.flex.utils
 				{
 					theConsole = window.console;
 				}
+				else if(typeof console !== "undefined")
+				{
+					theConsole = console;
+				}
 			}
 
 			try