You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by David E Jones <jo...@undersunconsulting.com> on 2006/11/01 19:35:03 UTC
Need Feedback on Design Issue (was: Re: [jira] Commented: (OFBIZ-333) ServiceMultiEventHandler to support configurable global transaction)
We need some feedback on a design issue.
The question is where to put the configuration option for specifying
whether or not to wrap the multiple service calls from the service-
multi event handler in a single transaction.
Where would people prefer to configure this option? The two main
places are probably either the event element in the controller.xml
file where the service-multi even handler is specified, or on the
service element in the service definition XML file where the other
transaction related attributes are defined.
Please express your opinion on this! We'd like to make a decision and
get this in soon.
-David
On Nov 1, 2006, at 10:56 AM, Si Chen (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/OFBIZ-333?
> page=comments#action_12446323 ]
>
> Si Chen commented on OFBIZ-333:
> -------------------------------
>
> Hmm...just you and me on this one, it seems. Well, are you ok
> enough with it to put it in?
>
>> ServiceMultiEventHandler to support configurable global transaction
>> -------------------------------------------------------------------
>>
>> Key: OFBIZ-333
>> URL: http://issues.apache.org/jira/browse/OFBIZ-333
>> Project: OFBiz (The Open for Business Project)
>> Issue Type: Improvement
>> Components: framework
>> Reporter: Si Chen
>> Attachments: ofbiz-333.2.patch, ofbiz133-1.patch
>>
>>
>> This is a continuation of OFBIZ-201: the ServiceMultiEventHandler
>> will be enhanced to support configurable global transaction. This
>> will be done by adding a "global-transaction" attribute to the
>> event tag:
>> <event type="service-multi" path=""
>> invoke="quickScheduleShipmentRouteSegment"/>
>> for global-transaction="true|false" which defaults to true. If
>> global-transaction="false" then there will be no
>> TransactionUtil.begin(..) and commit(..) around the services
>> calls. Instead, each service will be called with its own
>> transaction, and whatever messages it returns will be added to a
>> List of messages to be sent back to the request.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the
> administrators: http://issues.apache.org/jira/secure/
> Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/
> software/jira
>
>
Re: Need Feedback on Design Issue
Posted by Jacques Le Roux <ja...@les7arts.com>.
Yes at root (controller ) seems easier for a beginning.
Service definition of type "service-multi" seems a good idea to me.
Jacques
> Adding it to the controller would be enough for now.
> For the future we could maybe consider to wrap the service in a new
> service definition of type "service-multi" and add the transaction
> properties there.
>
> Jacopo
>
>
> David E Jones wrote:
> >
> > We need some feedback on a design issue.
> >
> > The question is where to put the configuration option for specifying
> > whether or not to wrap the multiple service calls from the service-multi
> > event handler in a single transaction.
> >
> > Where would people prefer to configure this option? The two main places
> > are probably either the event element in the controller.xml file where
> > the service-multi even handler is specified, or on the service element
> > in the service definition XML file where the other transaction related
> > attributes are defined.
> >
> > Please express your opinion on this! We'd like to make a decision and
> > get this in soon.
> >
> > -David
> >
> >
> > On Nov 1, 2006, at 10:56 AM, Si Chen (JIRA) wrote:
> >
> >> [
> >> http://issues.apache.org/jira/browse/OFBIZ-333?page=comments#action_12446323
> >> ]
> >>
> >> Si Chen commented on OFBIZ-333:
> >> -------------------------------
> >>
> >> Hmm...just you and me on this one, it seems. Well, are you ok enough
> >> with it to put it in?
> >>
> >>> ServiceMultiEventHandler to support configurable global transaction
> >>> -------------------------------------------------------------------
> >>>
> >>> Key: OFBIZ-333
> >>> URL: http://issues.apache.org/jira/browse/OFBIZ-333
> >>> Project: OFBiz (The Open for Business Project)
> >>> Issue Type: Improvement
> >>> Components: framework
> >>> Reporter: Si Chen
> >>> Attachments: ofbiz-333.2.patch, ofbiz133-1.patch
> >>>
> >>>
> >>> This is a continuation of OFBIZ-201: the ServiceMultiEventHandler
> >>> will be enhanced to support configurable global transaction. This
> >>> will be done by adding a "global-transaction" attribute to the event
> >>> tag:
> >>> <event type="service-multi" path=""
> >>> invoke="quickScheduleShipmentRouteSegment"/>
> >>> for global-transaction="true|false" which defaults to true. If
> >>> global-transaction="false" then there will be no
> >>> TransactionUtil.begin(..) and commit(..) around the services calls.
> >>> Instead, each service will be called with its own transaction, and
> >>> whatever messages it returns will be added to a List of messages to
> >>> be sent back to the request.
> >>
> >> --This message is automatically generated by JIRA.
> >> -
> >> If you think it was sent incorrectly contact one of the
> >> administrators: http://issues.apache.org/jira/secure/Administrators.jspa
> >> -
> >> For more information on JIRA, see: http://www.atlassian.com/software/jira
> >>
> >>
Re: Need Feedback on Design Issue
Posted by Jacopo Cappellato <ti...@sastau.it>.
Adding it to the controller would be enough for now.
For the future we could maybe consider to wrap the service in a new
service definition of type "service-multi" and add the transaction
properties there.
Jacopo
David E Jones wrote:
>
> We need some feedback on a design issue.
>
> The question is where to put the configuration option for specifying
> whether or not to wrap the multiple service calls from the service-multi
> event handler in a single transaction.
>
> Where would people prefer to configure this option? The two main places
> are probably either the event element in the controller.xml file where
> the service-multi even handler is specified, or on the service element
> in the service definition XML file where the other transaction related
> attributes are defined.
>
> Please express your opinion on this! We'd like to make a decision and
> get this in soon.
>
> -David
>
>
> On Nov 1, 2006, at 10:56 AM, Si Chen (JIRA) wrote:
>
>> [
>> http://issues.apache.org/jira/browse/OFBIZ-333?page=comments#action_12446323
>> ]
>>
>> Si Chen commented on OFBIZ-333:
>> -------------------------------
>>
>> Hmm...just you and me on this one, it seems. Well, are you ok enough
>> with it to put it in?
>>
>>> ServiceMultiEventHandler to support configurable global transaction
>>> -------------------------------------------------------------------
>>>
>>> Key: OFBIZ-333
>>> URL: http://issues.apache.org/jira/browse/OFBIZ-333
>>> Project: OFBiz (The Open for Business Project)
>>> Issue Type: Improvement
>>> Components: framework
>>> Reporter: Si Chen
>>> Attachments: ofbiz-333.2.patch, ofbiz133-1.patch
>>>
>>>
>>> This is a continuation of OFBIZ-201: the ServiceMultiEventHandler
>>> will be enhanced to support configurable global transaction. This
>>> will be done by adding a "global-transaction" attribute to the event
>>> tag:
>>> <event type="service-multi" path=""
>>> invoke="quickScheduleShipmentRouteSegment"/>
>>> for global-transaction="true|false" which defaults to true. If
>>> global-transaction="false" then there will be no
>>> TransactionUtil.begin(..) and commit(..) around the services calls.
>>> Instead, each service will be called with its own transaction, and
>>> whatever messages it returns will be added to a List of messages to
>>> be sent back to the request.
>>
>> --This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of the
>> administrators: http://issues.apache.org/jira/secure/Administrators.jspa
>> -
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
Re: Need Feedback on Design Issue (was: Re: [jira] Commented: (OFBIZ-333) ServiceMultiEventHandler to support configurable global transaction)
Posted by Chris Howe <cj...@yahoo.com>.
There is no hard and fast rule about which to use.
However, I see the primary benefit of a subelement as
being learning curve. As needs arise to expand the
event definition further utilizing a subelement for
this will make the definition less ambiguous what each
attribute is referring to.
The form widget is an example of this with its 40+
attributes. Dropping the style related attributes into
a sub element would reduce the learning curve as
someone trying to learn a simple form definition can
ignore the nuances of styling it until they need to
tackle those nuances. The same principle applies with
the even definition.
Either way, placing the config options in the
controller is much more flexible than placing in the
service definition.
--- David E Jones <jo...@undersunconsulting.com>
wrote:
>
> On Nov 1, 2006, at 12:06 PM, Chris Howe wrote:
>
> > I would prefer in the controller.xml as a
> subelement
> > (as opposed to attribute) to the <event> tag as
> > additional config parameters may be beneficial in
> the
> > future.
>
> That is what attributes are good for... subelements
> involve more
> overhead in the schema, eventual XML file, and the
> processing code.
>
> What would the benefit of a subelement be?
>
> -David
>
>
> > Putting it at the service definition would limit
> it's
> > flexibility.
> >
> > --- David E Jones <jo...@undersunconsulting.com>
> > wrote:
> >
> >>
> >> We need some feedback on a design issue.
> >>
> >> The question is where to put the configuration
> >> option for specifying
> >> whether or not to wrap the multiple service calls
> >> from the service-
> >> multi event handler in a single transaction.
> >>
> >> Where would people prefer to configure this
> option?
> >> The two main
> >> places are probably either the event element in
> the
> >> controller.xml
> >> file where the service-multi even handler is
> >> specified, or on the
> >> service element in the service definition XML
> file
> >> where the other
> >> transaction related attributes are defined.
> >>
> >> Please express your opinion on this! We'd like to
> >> make a decision and
> >> get this in soon.
> >>
> >> -David
> >>
> >>
> >> On Nov 1, 2006, at 10:56 AM, Si Chen (JIRA)
> wrote:
> >>
> >>> [
> >> http://issues.apache.org/jira/browse/OFBIZ-333?
> >>> page=comments#action_12446323 ]
> >>>
> >>> Si Chen commented on OFBIZ-333:
> >>> -------------------------------
> >>>
> >>> Hmm...just you and me on this one, it seems.
> >> Well, are you ok
> >>> enough with it to put it in?
> >>>
> >>>> ServiceMultiEventHandler to support
> configurable
> >> global transaction
> >>>>
> >>
> >
>
-------------------------------------------------------------------
> >>>>
> >>>> Key: OFBIZ-333
> >>>> URL:
> >> http://issues.apache.org/jira/browse/OFBIZ-333
> >>>> Project: OFBiz (The Open for
> Business
> >> Project)
> >>>> Issue Type: Improvement
> >>>> Components: framework
> >>>> Reporter: Si Chen
> >>>> Attachments: ofbiz-333.2.patch,
> >> ofbiz133-1.patch
> >>>>
> >>>>
> >>>> This is a continuation of OFBIZ-201: the
> >> ServiceMultiEventHandler
> >>>> will be enhanced to support configurable global
> >> transaction. This
> >>>> will be done by adding a "global-transaction"
> >> attribute to the
> >>>> event tag:
> >>>> <event type="service-multi" path=""
> >>>> invoke="quickScheduleShipmentRouteSegment"/>
> >>>> for global-transaction="true|false" which
> >> defaults to true. If
> >>>> global-transaction="false" then there will be
> no
> >>
> >>>> TransactionUtil.begin(..) and commit(..) around
> >> the services
> >>>> calls. Instead, each service will be called
> with
> >> its own
> >>>> transaction, and whatever messages it returns
> >> will be added to a
> >>>> List of messages to be sent back to the
> request.
> >>>
> >>> --
> >>> This message is automatically generated by JIRA.
> >>> -
> >>> If you think it was sent incorrectly contact one
> >> of the
> >>> administrators:
> >> http://issues.apache.org/jira/secure/
> >>> Administrators.jspa
> >>> -
> >>> For more information on JIRA, see:
> >> http://www.atlassian.com/
> >>> software/jira
> >>>
> >>>
> >>
> >>
> >
>
>
Re: Need Feedback on Design Issue (was: Re: [jira] Commented: (OFBIZ-333) ServiceMultiEventHandler to support configurable global transaction)
Posted by David E Jones <jo...@undersunconsulting.com>.
On Nov 1, 2006, at 12:06 PM, Chris Howe wrote:
> I would prefer in the controller.xml as a subelement
> (as opposed to attribute) to the <event> tag as
> additional config parameters may be beneficial in the
> future.
That is what attributes are good for... subelements involve more
overhead in the schema, eventual XML file, and the processing code.
What would the benefit of a subelement be?
-David
> Putting it at the service definition would limit it's
> flexibility.
>
> --- David E Jones <jo...@undersunconsulting.com>
> wrote:
>
>>
>> We need some feedback on a design issue.
>>
>> The question is where to put the configuration
>> option for specifying
>> whether or not to wrap the multiple service calls
>> from the service-
>> multi event handler in a single transaction.
>>
>> Where would people prefer to configure this option?
>> The two main
>> places are probably either the event element in the
>> controller.xml
>> file where the service-multi even handler is
>> specified, or on the
>> service element in the service definition XML file
>> where the other
>> transaction related attributes are defined.
>>
>> Please express your opinion on this! We'd like to
>> make a decision and
>> get this in soon.
>>
>> -David
>>
>>
>> On Nov 1, 2006, at 10:56 AM, Si Chen (JIRA) wrote:
>>
>>> [
>> http://issues.apache.org/jira/browse/OFBIZ-333?
>>> page=comments#action_12446323 ]
>>>
>>> Si Chen commented on OFBIZ-333:
>>> -------------------------------
>>>
>>> Hmm...just you and me on this one, it seems.
>> Well, are you ok
>>> enough with it to put it in?
>>>
>>>> ServiceMultiEventHandler to support configurable
>> global transaction
>>>>
>>
> -------------------------------------------------------------------
>>>>
>>>> Key: OFBIZ-333
>>>> URL:
>> http://issues.apache.org/jira/browse/OFBIZ-333
>>>> Project: OFBiz (The Open for Business
>> Project)
>>>> Issue Type: Improvement
>>>> Components: framework
>>>> Reporter: Si Chen
>>>> Attachments: ofbiz-333.2.patch,
>> ofbiz133-1.patch
>>>>
>>>>
>>>> This is a continuation of OFBIZ-201: the
>> ServiceMultiEventHandler
>>>> will be enhanced to support configurable global
>> transaction. This
>>>> will be done by adding a "global-transaction"
>> attribute to the
>>>> event tag:
>>>> <event type="service-multi" path=""
>>>> invoke="quickScheduleShipmentRouteSegment"/>
>>>> for global-transaction="true|false" which
>> defaults to true. If
>>>> global-transaction="false" then there will be no
>>
>>>> TransactionUtil.begin(..) and commit(..) around
>> the services
>>>> calls. Instead, each service will be called with
>> its own
>>>> transaction, and whatever messages it returns
>> will be added to a
>>>> List of messages to be sent back to the request.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> If you think it was sent incorrectly contact one
>> of the
>>> administrators:
>> http://issues.apache.org/jira/secure/
>>> Administrators.jspa
>>> -
>>> For more information on JIRA, see:
>> http://www.atlassian.com/
>>> software/jira
>>>
>>>
>>
>>
>
Re: Need Feedback on Design Issue (was: Re: [jira] Commented: (OFBIZ-333) ServiceMultiEventHandler to support configurable global transaction)
Posted by Chris Howe <cj...@yahoo.com>.
I would prefer in the controller.xml as a subelement
(as opposed to attribute) to the <event> tag as
additional config parameters may be beneficial in the
future.
Putting it at the service definition would limit it's
flexibility.
--- David E Jones <jo...@undersunconsulting.com>
wrote:
>
> We need some feedback on a design issue.
>
> The question is where to put the configuration
> option for specifying
> whether or not to wrap the multiple service calls
> from the service-
> multi event handler in a single transaction.
>
> Where would people prefer to configure this option?
> The two main
> places are probably either the event element in the
> controller.xml
> file where the service-multi even handler is
> specified, or on the
> service element in the service definition XML file
> where the other
> transaction related attributes are defined.
>
> Please express your opinion on this! We'd like to
> make a decision and
> get this in soon.
>
> -David
>
>
> On Nov 1, 2006, at 10:56 AM, Si Chen (JIRA) wrote:
>
> > [
> http://issues.apache.org/jira/browse/OFBIZ-333?
> > page=comments#action_12446323 ]
> >
> > Si Chen commented on OFBIZ-333:
> > -------------------------------
> >
> > Hmm...just you and me on this one, it seems.
> Well, are you ok
> > enough with it to put it in?
> >
> >> ServiceMultiEventHandler to support configurable
> global transaction
> >>
>
-------------------------------------------------------------------
> >>
> >> Key: OFBIZ-333
> >> URL:
> http://issues.apache.org/jira/browse/OFBIZ-333
> >> Project: OFBiz (The Open for Business
> Project)
> >> Issue Type: Improvement
> >> Components: framework
> >> Reporter: Si Chen
> >> Attachments: ofbiz-333.2.patch,
> ofbiz133-1.patch
> >>
> >>
> >> This is a continuation of OFBIZ-201: the
> ServiceMultiEventHandler
> >> will be enhanced to support configurable global
> transaction. This
> >> will be done by adding a "global-transaction"
> attribute to the
> >> event tag:
> >> <event type="service-multi" path=""
> >> invoke="quickScheduleShipmentRouteSegment"/>
> >> for global-transaction="true|false" which
> defaults to true. If
> >> global-transaction="false" then there will be no
>
> >> TransactionUtil.begin(..) and commit(..) around
> the services
> >> calls. Instead, each service will be called with
> its own
> >> transaction, and whatever messages it returns
> will be added to a
> >> List of messages to be sent back to the request.
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > If you think it was sent incorrectly contact one
> of the
> > administrators:
> http://issues.apache.org/jira/secure/
> > Administrators.jspa
> > -
> > For more information on JIRA, see:
> http://www.atlassian.com/
> > software/jira
> >
> >
>
>