You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2022/11/02 21:27:11 UTC
[arrow] branch master updated: ARROW-18051: [C++] Enable tests skipped by ARROW-16392 (#14425)
This is an automated email from the ASF dual-hosted git repository.
westonpace pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 6810df2cdd ARROW-18051: [C++] Enable tests skipped by ARROW-16392 (#14425)
6810df2cdd is described below
commit 6810df2cdd0847e2ca98f73775cdd3abc036f681
Author: Vibhatha Lakmal Abeykoon <vi...@users.noreply.github.com>
AuthorDate: Thu Nov 3 02:57:05 2022 +0530
ARROW-18051: [C++] Enable tests skipped by ARROW-16392 (#14425)
Removing skip test macros from the C++ tests.
Authored-by: Vibhatha Lakmal Abeykoon <vi...@gmail.com>
Signed-off-by: Weston Pace <we...@gmail.com>
---
cpp/src/arrow/engine/substrait/serde_test.cc | 30 ----------------------------
cpp/src/arrow/flight/sql/acero_test.cc | 16 ---------------
2 files changed, 46 deletions(-)
diff --git a/cpp/src/arrow/engine/substrait/serde_test.cc b/cpp/src/arrow/engine/substrait/serde_test.cc
index b3790ac240..f3f5be3bb2 100644
--- a/cpp/src/arrow/engine/substrait/serde_test.cc
+++ b/cpp/src/arrow/engine/substrait/serde_test.cc
@@ -1997,9 +1997,6 @@ TEST(Substrait, AggregateBadPhase) {
}
TEST(Substrait, BasicPlanRoundTripping) {
-#ifdef _WIN32
- GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
-#endif
compute::ExecContext exec_context;
arrow::dataset::internal::Initialize();
@@ -2111,9 +2108,6 @@ TEST(Substrait, BasicPlanRoundTripping) {
}
TEST(Substrait, BasicPlanRoundTrippingEndToEnd) {
-#ifdef _WIN32
- GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
-#endif
compute::ExecContext exec_context;
arrow::dataset::internal::Initialize();
@@ -2227,9 +2221,6 @@ TEST(Substrait, BasicPlanRoundTrippingEndToEnd) {
}
TEST(Substrait, ProjectRel) {
-#ifdef _WIN32
- GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
-#endif
compute::ExecContext exec_context;
auto dummy_schema =
schema({field("A", int32()), field("B", int32()), field("C", int32())});
@@ -2344,9 +2335,6 @@ TEST(Substrait, ProjectRel) {
}
TEST(Substrait, ProjectRelOnFunctionWithEmit) {
-#ifdef _WIN32
- GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
-#endif
compute::ExecContext exec_context;
auto dummy_schema =
schema({field("A", int32()), field("B", int32()), field("C", int32())});
@@ -2465,9 +2453,6 @@ TEST(Substrait, ProjectRelOnFunctionWithEmit) {
}
TEST(Substrait, ReadRelWithEmit) {
-#ifdef _WIN32
- GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
-#endif
compute::ExecContext exec_context;
auto dummy_schema =
schema({field("A", int32()), field("B", int32()), field("C", int32())});
@@ -2526,9 +2511,6 @@ TEST(Substrait, ReadRelWithEmit) {
}
TEST(Substrait, FilterRelWithEmit) {
-#ifdef _WIN32
- GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
-#endif
compute::ExecContext exec_context;
auto dummy_schema = schema({field("A", int32()), field("B", int32()),
field("C", int32()), field("D", int32())});
@@ -2646,9 +2628,6 @@ TEST(Substrait, FilterRelWithEmit) {
}
TEST(Substrait, JoinRelEndToEnd) {
-#ifdef _WIN32
- GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
-#endif
compute::ExecContext exec_context;
auto left_schema = schema({field("A", int32()), field("B", int32())});
@@ -2798,9 +2777,6 @@ TEST(Substrait, JoinRelEndToEnd) {
}
TEST(Substrait, JoinRelWithEmit) {
-#ifdef _WIN32
- GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
-#endif
compute::ExecContext exec_context;
auto left_schema = schema({field("A", int32()), field("B", int32())});
@@ -2952,9 +2928,6 @@ TEST(Substrait, JoinRelWithEmit) {
}
TEST(Substrait, AggregateRel) {
-#ifdef _WIN32
- GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
-#endif
compute::ExecContext exec_context;
auto dummy_schema =
schema({field("A", int32()), field("B", int32()), field("C", int32())});
@@ -3063,9 +3036,6 @@ TEST(Substrait, AggregateRel) {
}
TEST(Substrait, AggregateRelEmit) {
-#ifdef _WIN32
- GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
-#endif
compute::ExecContext exec_context;
auto dummy_schema =
schema({field("A", int32()), field("B", int32()), field("C", int32())});
diff --git a/cpp/src/arrow/flight/sql/acero_test.cc b/cpp/src/arrow/flight/sql/acero_test.cc
index fd3c52e74f..9c3f99426f 100644
--- a/cpp/src/arrow/flight/sql/acero_test.cc
+++ b/cpp/src/arrow/flight/sql/acero_test.cc
@@ -140,10 +140,6 @@ TEST_F(TestAcero, GetSqlInfo) {
}
TEST_F(TestAcero, Scan) {
-#ifdef _WIN32
- GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
-#endif
-
FlightCallOptions call_options;
ASSERT_OK_AND_ASSIGN(auto serialized_plan, MakeSubstraitPlan());
@@ -169,10 +165,6 @@ TEST_F(TestAcero, Scan) {
}
TEST_F(TestAcero, Update) {
-#ifdef _WIN32
- GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
-#endif
-
FlightCallOptions call_options;
ASSERT_OK_AND_ASSIGN(auto serialized_plan, MakeSubstraitPlan());
SubstraitPlan plan{serialized_plan->ToString(), /*version=*/"0.6.0"};
@@ -182,10 +174,6 @@ TEST_F(TestAcero, Update) {
}
TEST_F(TestAcero, Prepare) {
-#ifdef _WIN32
- GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
-#endif
-
FlightCallOptions call_options;
ASSERT_OK_AND_ASSIGN(auto serialized_plan, MakeSubstraitPlan());
SubstraitPlan plan{serialized_plan->ToString(), /*version=*/"0.6.0"};
@@ -217,10 +205,6 @@ TEST_F(TestAcero, Prepare) {
}
TEST_F(TestAcero, Transactions) {
-#ifdef _WIN32
- GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
-#endif
-
FlightCallOptions call_options;
ASSERT_OK_AND_ASSIGN(auto serialized_plan, MakeSubstraitPlan());
Transaction handle("fake-id");