[GitHub] [beam] robertwb commented on a change in pull request #15889: [BEAM-13187] Set filesToStage after local path has been resolved

[GitBox <gi...@apache.org>]

robertwb commented on a change in pull request #15889:
URL: https://github.com/apache/beam/pull/15889#discussion_r742459260



##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -670,7 +670,8 @@ def __enter__(self):
       self._service_provider = subprocess_server.JavaJarServer(
           ExpansionAndArtifactRetrievalStub,
           self._path_to_jar,
-          self._extra_args)
+          self._extra_args + [f'--filesToStage={self._path_to_jar}'],

Review comment:
       Let's keep the same behavior, otherwise a user has no way of not specifying this argument (if, say, they have an expansion service not based on our jar). 

##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -670,7 +670,8 @@ def __enter__(self):
       self._service_provider = subprocess_server.JavaJarServer(
           ExpansionAndArtifactRetrievalStub,
           self._path_to_jar,
-          self._extra_args)
+          self._extra_args + [f'--filesToStage={self._path_to_jar}'],

Review comment:
       (This is what I did in https://github.com/apache/beam/pull/15891 . I still think it'd be good to get this in for the release, but if it's the only change that we'd need to CP I'll defer to the release manager as whether it meets the bar.)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org