You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/24 21:54:52 UTC

[GitHub] [airflow] eladkal commented on issue #14359: upgrade_check fails on ImportChangesRule

eladkal commented on issue #14359:
URL: https://github.com/apache/airflow/issues/14359#issuecomment-785410104


   The easiest way to solve this is not to use `current_airflow_version.major` as this works only with `packaging >= 20.0`
   https://github.com/pypa/packaging/blob/main/CHANGELOG.rst#200---2020-01-06
   We don't have minimum requirement for [packaging](https://github.com/apache/airflow/blob/e33313302173b6bd872523ced233acc26ff9d6fe/setup.py#L635)
   So this just need to change https://github.com/apache/airflow/blob/e33313302173b6bd872523ced233acc26ff9d6fe/airflow/upgrade/rules/import_changes.py#L130
   from:
   `if current_airflow_version.major >= 2:`
   to
   `if current_airflow_version >= Version("2.0.0"):`
   
   I'll PR shortly
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org