You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "James Holmes (JIRA)" <ji...@apache.org> on 2007/08/23 19:05:35 UTC

[jira] Issue Comment Edited: (WW-2132) Add support for JSP tag library dynamic attributes

    [ https://issues.apache.org/struts/browse/WW-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42000 ] 

jholmes edited comment on WW-2132 at 8/23/07 10:04 AM:
------------------------------------------------------------

There are several changes that need to be made to support this. Here is the list:

+ Update struts-annotation project to support generating a <dynamic-attributes> entry in TLD files.
+ Update StrutsTag annotation to have an allowDynamicAttributes field.
+ Update UI tags to specify an allowDynamicAttributes on their StrutsTag annotations.
+ Update org.apache.struts2.views.jsp.ui.AbstractUITag to implement javax.servlet.jsp.tagext.DynamicAttributes.
+ Add JUnit tests for new allowDynamicAttributes annotation property.
+ Update FreeMarker templates to output dynamic attributes if present.
+ Update struts2/core/pom.xml to output 2 TLDs: struts-tags.tld and struts-tags-dynamic.tld.
+ Update documentation.

Feedback is welcome and encouraged. My design is based around how Stripes implements this. Stripes provides a dynamic and non-dynamic version of the TLD and leaves it up to the user to decide which to use. We can follow that approach or simply have dynamic be the only option.


      was (Author: jholmes):
    There are several changes that need to be made to support this. Here is the list:

+ Update struts-annotation project to support generating a <dynamic-attributes> entry in TLD files.
+ Update StrutsTag annotation to have an allowDynamicAttributes field.
+ Update UI tags to specify an allowDynamicAttributes on their StrutsTag annotations.
+ Update org.apache.struts2.views.jsp.ui.AbstractUITag to implement javax.servlet.jsp.tagext.DynamicAttributes.
+ Update FreeMarker templates to output dynamic attributes if present.
+ Update struts2/core/pom.xml to output 2 TLDs: struts-tags.tld and struts-tags-dynamic.tld.
+ Update documentation.

Feedback is welcome and encouraged. My design is based around how Stripes implements this. Stripes provides a dynamic and non-dynamic version of the TLD and leaves it up to the user to decide which to use. We can follow that approach or simply have dynamic be the only option.

  
> Add support for JSP tag library dynamic attributes
> --------------------------------------------------
>
>                 Key: WW-2132
>                 URL: https://issues.apache.org/struts/browse/WW-2132
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.1.0
>            Reporter: James Holmes
>            Assignee: James Holmes
>             Fix For: 2.1.0
>
>
> Based on the discussion in WW-2092, I am working on adding support for JSP dynamic attributes to Struts 2.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.