You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Sébastien Brisard <se...@m4x.org> on 2012/07/13 13:36:35 UTC

Re: svn commit: r1361164 - /commons/proper/math/trunk/src/test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java

Hi Gilles,

2012/7/13  <er...@apache.org>:
> Author: erans
> Date: Fri Jul 13 11:20:42 2012
> New Revision: 1361164
>
> URL: http://svn.apache.org/viewvc?rev=1361164&view=rev
> Log:
> Two failing tests temporarily disabled until MATH-821 is fixed.
>
> Modified:
>     commons/proper/math/trunk/src/test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java
>
> Modified: commons/proper/math/trunk/src/test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java
> URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java?rev=1361164&r1=1361163&r2=1361164&view=diff
> ==============================================================================
> --- commons/proper/math/trunk/src/test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java (original)
> +++ commons/proper/math/trunk/src/test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java Fri Jul 13 11:20:42 2012
> @@ -97,4 +97,22 @@ public class SparseRealVectorTest extend
>          u.ebeMultiply(v1);
>          u.ebeDivide(v1);
>      }
> +
> +    /**
> +     * XXX This test is disabled because it currently fails.
> +     * The bug must still be fixed in the sparse vector implementation.
> +     * When this is done, this override should be deleted.
> +     */
> +    @Test
> +    @Override
> +    public void testMap() {}
> +
> +    /**
> +     * XXX This test is disabled because it currently fails.
> +     * The bug must still be fixed in the sparse vector implementation.
> +     * When this is done, this override should be deleted.
> +     */
> +    @Test
> +    @Override
> +    public void testMapToSelf() {}
>  }
>
>

We could simply have overriden createFunctions() in
RealVectorAbstractTest(), but your solution is fine! I just took the
liberty to add a @Ignore tag, which shows a message in the tests
reports, just in case we forget to reenable this test.

Best regards,
Sébastien


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1361164 - /commons/proper/math/trunk/src/test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java

Posted by Sébastien Brisard <se...@m4x.org>.
Hello,

>>
>>> [...] I just took the
>>> liberty to add a @Ignore tag, which shows a message in the tests
>>> reports, just in case we forget to reenable this test.
>>
>> Yes. That's cleaner. Thanks.
>>
>> However, the "skipped" message does not appear in the "txt" reports.
>> It's there in the "xml" report. Is there a flag to set on the commad-line in
>> order to generate HTML pages from those?
>>
> I think mvn site:site will generate a surefire report with those
> messages included. As for the txt reports, I will investigate.
>
I've quickly had a look to the internet, and could not find anything
regarding the txt reports. The closest thing I found was this issue
http://jira.codehaus.org/browse/SUREFIRE-537
but it's marked as resolved.

The good news is that the surefire report generated by mvn site:site
does show the reason why the test is being skipped.

Sébastien


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1361164 - /commons/proper/math/trunk/src/test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java

Posted by Sébastien Brisard <se...@m4x.org>.
Hi,

2012/7/13 Gilles Sadowski <gi...@harfang.homelinux.org>:
> Hi.
>
>> [...] I just took the
>> liberty to add a @Ignore tag, which shows a message in the tests
>> reports, just in case we forget to reenable this test.
>
> Yes. That's cleaner. Thanks.
>
> However, the "skipped" message does not appear in the "txt" reports.
> It's there in the "xml" report. Is there a flag to set on the commad-line in
> order to generate HTML pages from those?
>
I think mvn site:site will generate a surefire report with those
messages included. As for the txt reports, I will investigate.

Best regards,
Sébastien


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1361164 - /commons/proper/math/trunk/src/test/java/org/apache/commons/math3/linear/SparseRealVectorTest.java

Posted by Gilles Sadowski <gi...@harfang.homelinux.org>.
Hi.

> [...] I just took the
> liberty to add a @Ignore tag, which shows a message in the tests
> reports, just in case we forget to reenable this test.

Yes. That's cleaner. Thanks.

However, the "skipped" message does not appear in the "txt" reports.
It's there in the "xml" report. Is there a flag to set on the commad-line in
order to generate HTML pages from those?

Regards,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org