You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/08 21:02:50 UTC
[GitHub] [superset] opus-42 opened a new pull request #18626: Feat/editable title xl certified badge
opus-42 opened a new pull request #18626:
URL: https://github.com/apache/superset/pull/18626
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
I propose to increase it the size of the Certified Badge to XL instead of L (default) when using it Editable Title.
Other certified badge size are left in default size.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**Before**
<img width="322" alt="image" src="https://user-images.githubusercontent.com/33355870/153074829-0a67e01d-a4ae-4310-b0ab-6a0e11ad7dd6.png">
**After**
<img width="305" alt="image" src="https://user-images.githubusercontent.com/33355870/153074354-9d2ebaf5-c912-47c3-a188-9546220ff28f.png">
### TESTING INSTRUCTIONS
Go into a dashboard with certification. Badge with XL size should appear on the left of the title
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 merged pull request #18626: feat: editable title xl certified badge
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #18626:
URL: https://github.com/apache/superset/pull/18626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org