You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dengziming (via GitHub)" <gi...@apache.org> on 2025/03/05 12:31:26 UTC
[PR] HOTFIX: Do not use highest version when version is valid [kafka]
dengziming opened a new pull request, #19109:
URL: https://github.com/apache/kafka/pull/19109
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HOTFIX: Do not use highest version when version is valid [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #19109:
URL: https://github.com/apache/kafka/pull/19109#issuecomment-2704368275
Can we add a test for this? The fact that we added a pretty serious bug and no test failed is important to address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HOTFIX: Do not use highest version when version is valid [kafka]
Posted by "dengziming (via GitHub)" <gi...@apache.org>.
dengziming commented on PR #19109:
URL: https://github.com/apache/kafka/pull/19109#issuecomment-2705871265
Hello @ijuma @chia7712 .
The existing test cases are sufficient for spotting this bug, they didn't fail because we didn't bump the version in the previous PR.
If we bump the version to 1 adding a new field, then several test cases would fail on `java.nio.BufferUnderflowException` because it treat version-0-buffer as version-1-buffer but unable to read new data.
I also validated it locally:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HOTFIX: Do not use highest version when version is valid [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #19109:
URL: https://github.com/apache/kafka/pull/19109#issuecomment-2704555256
> Can we add a test for this? The fact that we added a pretty serious bug and no test failed is important to address.
Sure. @dengziming do you have free cycle to address it? If not, I can take over it tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HOTFIX: Do not use highest version when version is valid [kafka]
Posted by "dengziming (via GitHub)" <gi...@apache.org>.
dengziming commented on PR #19109:
URL: https://github.com/apache/kafka/pull/19109#issuecomment-2705371671
> do you have free cycle to address
@chia7712 Yes, I thought about testing it initially, however, we only have one possible version for this schema. I think I need to bypass the auto-protocol and construct it directly from byte buffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HOTFIX: Do not use highest version when version is valid [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #19109:
URL: https://github.com/apache/kafka/pull/19109#issuecomment-2707189281
@dengziming maybe we can leverage `Mockito.mockConstruction` to ensure the version passed to `EndTxnMarker` is less or equal to `EndTxnMarker.HIGHEST_SUPPORTED_VERSION`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HOTFIX: Do not use highest version when version is valid [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #19109:
URL: https://github.com/apache/kafka/pull/19109#issuecomment-2707255402
Thanks for checking this @dengziming. Given what you described, I am ok if we don't add a new test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HOTFIX: Do not use highest version when version is valid [kafka]
Posted by "dengziming (via GitHub)" <gi...@apache.org>.
dengziming commented on PR #19109:
URL: https://github.com/apache/kafka/pull/19109#issuecomment-2700803255
Hello @chia7712 , sorry for my negligence, I accidentally set highest version in all cases, it's influential currently but is a time bomb for future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HOTFIX: Do not use highest version when version is valid [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #19109:
URL: https://github.com/apache/kafka/pull/19109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org