You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2017/03/23 09:16:35 UTC
[GitHub] zeppelin pull request #2182: [ZEPPELIN-2248] Fix javax.ws.rs and cxf version...
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/2182
[ZEPPELIN-2248] Fix javax.ws.rs and cxf version mismatch
### What is this PR for?
Fixing version mismatch among jetty, cxf, jersey
### What type of PR is it?
[Bug Fix]
### Todos
* [x] - Match all versions of javax.ws related libraries
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2248
### How should this be tested?
No error while starting and accessing the web at the first time
### Screenshots (if appropriate)
N/A
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-2248
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2182.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2182
----
commit b04d47761ca58c87be83d66c67a508365b874705
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2017-03-12T09:57:29Z
Fixed cxf version to match with jetty version we use
Fixed jerysey version to meet with cxf version
Updated javax.ws.rs version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2182: [HOLD][ZEPPELIN-2248] Fix javax.ws.rs and cxf version ...
Posted by sohaibiftikhar <gi...@git.apache.org>.
Github user sohaibiftikhar commented on the issue:
https://github.com/apache/zeppelin/pull/2182
For some reason the jar conflict(with the no such method exception) keeps showing up for me when using shiro with `org.apache.zeppelin.realm.LdapRealm`. When I had earlier used `GroupLdapRealm` there was no issue. I am not really sure if this is the reason or it is plain chance. I can certainly help with testing it but do you know why the Jenkins test are failing with your merge request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2182: [ZEPPELIN-2248] Fix javax.ws.rs and cxf version mismat...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2182
This PR doesn't remove cxf, but just fixs the version mismatch issue. I'm not sure why we have to use cxf but I also don't know what the benefit is to remove cxf. This is WIP and I will focus only the minimum fix not to raise error when starting ZeppelinServer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2182: [ZEPPELIN-2248] Fix javax.ws.rs and cxf version mismat...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/2182
How does this PR relates to #932 ?
#932 simply replaces cxf with jersey2. Here I see we still have some cxf deps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2182: [ZEPPELIN-2248] Fix javax.ws.rs and cxf version mismat...
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/2182
This issue is recurring since a long time and depends IMHO on each environment (maven version...) - The main parameter to fix this is the `javax.ws.rsapi.version`.
This PR upgrades cxf from v2 to v3 and jersey from v1 to v2 which confuses me. I would rather see using only jersey2 as in #932.
Also Moving from jersey-v1 to jersey-v2 needs an update of the licence file as explained in #932.
Maybe the minimal fix would be leaving cxf as such and simply enforcing `javax.ws.rsapi.version` (I did that some time ago as temp fix).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2182: [HOLD][ZEPPELIN-2248] Fix javax.ws.rs and cxf version ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2182
Will close it as resolved by #932
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2182: [ZEPPELIN-2248] Fix javax.ws.rs and cxf version mismat...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2182
Hold until concluding #932
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2182: [HOLD][ZEPPELIN-2248] Fix javax.ws.rs and cxf version ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2182
@sohaibiftikhar Sorry for confusing you. I didn't know #932 set the CI. Please test it with that PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2182: [HOLD][ZEPPELIN-2248] Fix javax.ws.rs and cxf v...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul closed the pull request at:
https://github.com/apache/zeppelin/pull/2182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2182: [ZEPPELIN-2248] Fix javax.ws.rs and cxf version mismat...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2182
I got one error from travis. It seems to be related issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2182: [HOLD][ZEPPELIN-2248] Fix javax.ws.rs and cxf version ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2182
@sohaibiftikhar #932 didn't adopt CI then you'd better test this build and fix some minor issues from it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2182: [HOLD][ZEPPELIN-2248] Fix javax.ws.rs and cxf version ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2182
@sohaibiftikhar Hi, I'm holding it because of the former working #932 which looks similar to this. Can you share more about your problem? I'm actually blocked by disabling shiro. Without shiro, I don't know how to handle it. Can you test this PR? I decide to hold because it's one of minor issue but you suffer from the critical problem by this issue, I can handle it sooner with your help. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2182: [HOLD][ZEPPELIN-2248] Fix javax.ws.rs and cxf version ...
Posted by sohaibiftikhar <gi...@git.apache.org>.
Github user sohaibiftikhar commented on the issue:
https://github.com/apache/zeppelin/pull/2182
Hi, what is the status on this issue. Is there some temporary fix that can be used. Please tell me if you need help fixing/testing this issue. This is important because I cannot get LDAP to work if this keeps triggering on authorisation failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---