You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "RexXiong (via GitHub)" <gi...@apache.org> on 2023/06/29 07:39:34 UTC
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1661: [CELEBORN-748][REFACTOR] Rename RssHARetryClient to MasterClientWithRetry
RexXiong commented on code in PR #1661:
URL: https://github.com/apache/incubator-celeborn/pull/1661#discussion_r1246241630
##########
common/src/main/java/org/apache/celeborn/common/client/MasterClientWithRetry.java:
##########
@@ -48,8 +48,8 @@
import org.apache.celeborn.common.rpc.RpcTimeout;
import org.apache.celeborn.common.util.ThreadUtils;
-public class RssHARetryClient {
- private static final Logger LOG = LoggerFactory.getLogger(RssHARetryClient.class);
+public class MasterClientWithRetry {
Review Comment:
> No strong opinion, but I would call it `MasterClient` directly. What do you think? @waitinfuture @FMX
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org