[GitHub] [openwhisk] bdoyle0182 commented on a change in pull request #5169: add config option to disable successful non-blocking activation writes to db

[GitBox <gi...@apache.org>]

bdoyle0182 commented on a change in pull request #5169:
URL: https://github.com/apache/openwhisk/pull/5169#discussion_r780611886



##########
File path: common/scala/src/main/scala/org/apache/openwhisk/core/database/ActivationStore.scala
##########
@@ -35,21 +35,25 @@ case class UserContext(user: Identity, request: HttpRequest = HttpRequest())
 trait ActivationStore {
 
   protected val disableStoreResultConfig = loadConfigOrThrow[Boolean](ConfigKeys.disableStoreResult)
+  protected val disableStoreNonBlockingResultConfig = loadConfigOrThrow[Boolean](ConfigKeys.disableStoreNonBlockingResult)
   protected val unstoredLogsEnabledConfig = loadConfigOrThrow[Boolean](ConfigKeys.unstoredLogsEnabled)
 
   /**
    * Checks if an activation should be stored in database and stores it.
    *
    * @param activation activation to store
    * @param isBlockingActivation is activation blocking
+   * @param disableBlockingStore do not store activation if successful and blocking
+   * @param disableNonBlockingStore do not store activation if successful and non-blocking

Review comment:
       This is what I have. I can't think of a scenario where someone would want a subset of non blocking activations written, but not a larger subset for blocking. I can only think of wanting a subset of blocking and wanting a larger subset for non-blocking. I'll update the pr if you're good with this
   
   `STORE_ALWAYS`
   `STORE_NON_BLOCKING_OR_ON_BLOCKING_FAILURE`
   `STORE_ON_FAILURE`
   `STORE_ON_NON_APPLICATION_FAILURE`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org