You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/07/10 00:48:12 UTC

[GitHub] [phoenix] dbwong opened a new pull request #827: PHOENIX-5997 Phoenix Explain Plan for Deletes does not clearly differentiate between server side and client side paths.

dbwong opened a new pull request #827:
URL: https://github.com/apache/phoenix/pull/827


   https://issues.apache.org/jira/browse/PHOENIX-5997


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] gjacoby126 closed pull request #827: PHOENIX-5997 Phoenix Explain Plan for Deletes does not clearly differentiate between server side and client side paths.

Posted by GitBox <gi...@apache.org>.
gjacoby126 closed pull request #827:
URL: https://github.com/apache/phoenix/pull/827


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] dbwong commented on pull request #827: PHOENIX-5997 Phoenix Explain Plan for Deletes does not clearly differentiate between server side and client side paths.

Posted by GitBox <gi...@apache.org>.
dbwong commented on pull request #827:
URL: https://github.com/apache/phoenix/pull/827#issuecomment-656850618


   @gjacoby126 added header.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] dbwong commented on pull request #827: PHOENIX-5997 Phoenix Explain Plan for Deletes does not clearly differentiate between server side and client side paths.

Posted by GitBox <gi...@apache.org>.
dbwong commented on pull request #827:
URL: https://github.com/apache/phoenix/pull/827#issuecomment-656421280


   Whoops just noticed the formating is wrong let me fix that real quick.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] yanxinyi commented on pull request #827: PHOENIX-5997 Phoenix Explain Plan for Deletes does not clearly differentiate between server side and client side paths.

Posted by GitBox <gi...@apache.org>.
yanxinyi commented on pull request #827:
URL: https://github.com/apache/phoenix/pull/827#issuecomment-656961157


   @gjacoby126 Hi Geoffrey, is there anything else other than adding Apache License?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #827: PHOENIX-5997 Phoenix Explain Plan for Deletes does not clearly differentiate between server side and client side paths.

Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on a change in pull request #827:
URL: https://github.com/apache/phoenix/pull/827#discussion_r452885267



##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/ExplainPlanTextTest.java
##########
@@ -0,0 +1,52 @@
+package org.apache.phoenix.query;

Review comment:
       Missing an Apache License




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix] gjacoby126 commented on pull request #827: PHOENIX-5997 Phoenix Explain Plan for Deletes does not clearly differentiate between server side and client side paths.

Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #827:
URL: https://github.com/apache/phoenix/pull/827#issuecomment-683933388


   JIRA already committed, closing PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org