You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2016/02/01 16:50:42 UTC

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-windows/pull/147

    CB-10480 Remove Windows 8 template from cordova-windows

    [Jira issue](https://issues.apache.org/jira/browse/CB-10480)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-windows CB-10480

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #147
    
----
commit 8fdd8d01b89aac98a583f58a00051c0ce6fadb38
Author: daserge <v-...@microsoft.com>
Date:   2016-01-29T16:52:59Z

    CB-10480 Remove Windows 8 template from cordova-windows

commit 426ac4abb5abea3347dd722f32a47f9e60bec822
Author: daserge <v-...@microsoft.com>
Date:   2016-01-29T18:36:07Z

    CB-10480 Remove Windows 8 template from cordova-windows
    
    Updated the tests

commit c1cfa3b5a92d6f64d9257a82a2f51a80ee7ebcb4
Author: daserge <v-...@microsoft.com>
Date:   2016-02-01T15:41:33Z

    CB-10480 Remove Windows 8 template from cordova-windows
    
    Adds a friendly error message for windows-target-version = 8.0
    Updated check_reqs
    Updated the docs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-windows/pull/147#issuecomment-179031723
  
    Reviewed changes, :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-windows/pull/147#issuecomment-178816734
  
    +1
    Windows 8.0 has been deprecated since Apr 13, 2015, let's cleanup so we can provide better focus.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:

    https://github.com/apache/cordova-windows/pull/147#issuecomment-178059859
  
    This will be a breaking change, so yes, probably for cordova-windows@5.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

Posted by csantanapr <gi...@git.apache.org>.
Github user csantanapr commented on the pull request:

    https://github.com/apache/cordova-windows/pull/147#issuecomment-178054738
  
    For what version is this for? cordova-windows@5.0.0 ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-windows/pull/147


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org