[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4140: Return BooleanBuffer from BooleanBufferBuilder

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #4140:
URL: https://github.com/apache/arrow-rs/pull/4140#discussion_r1177792629


##########
arrow-array/src/builder/boolean_buffer_builder.rs:
##########
@@ -214,12 +214,12 @@ impl BooleanBufferBuilder {
         self.buffer.as_slice_mut()
     }
 
-    /// Creates a [`Buffer`]
+    /// Creates a [`BooleanBuffer`]
     #[inline]
-    pub fn finish(&mut self) -> Buffer {
+    pub fn finish(&mut self) -> BooleanBuffer {

Review Comment:
   I felt it was better to just break the API, than leaving the API in a somewhat incoherent state



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org