You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@annotator.apache.org by GitBox <gi...@apache.org> on 2020/03/28 00:28:14 UTC

[GitHub] [incubator-annotator] Treora opened a new pull request #68: Tweak demo style & text

Treora opened a new pull request #68: Tweak demo style & text
URL: https://github.com/apache/incubator-annotator/pull/68
 
 
   - remove dependencies on remote stylesheets, make a simple sheet instead
   - copy some styling&phrasing from the website’s demo
   - rephrase some text
   
   Bases on `reorg-webpack` (PR #67), so perhaps best to merge that first (this branch might not even conflict if it was based on master instead, but I did not try)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-annotator] Treora merged pull request #68: Tweak demo style & text

Posted by GitBox <gi...@apache.org>.

Treora merged pull request #68: Tweak demo style & text
URL: https://github.com/apache/incubator-annotator/pull/68
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-annotator] tilgovi commented on a change in pull request #68: Tweak demo style & text

Posted by GitBox <gi...@apache.org>.

tilgovi commented on a change in pull request #68: Tweak demo style & text
URL: https://github.com/apache/incubator-annotator/pull/68#discussion_r399739375
 
 

 ##########
 File path: web/demo/index.html
 ##########
 @@ -18,65 +18,90 @@
 -->
 <!doctype html>
 <html>
+<head>
   <meta charset="utf-8">
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="viewport" content="width=device-width, initial-scale=1">
   <title>Apache Annotator (incubating) demo</title>
-  <link rel="stylesheet" href="https://unpkg.com/awsm.css/dist/awsm.min.css">
+  <link rel="stylesheet" href="../style.css"/>
   <style>
-    blockquote {
-      font-style: italic;
-    }
     a[href^="#selector"]:before {
-      content: '📌';
-      font-size: 75%;
+      content: '📌 ';
     }
-    mark {
-      background-color: rgba(255, 255, 0, 0.5);
-      outline: 0.1px solid rgba(255, 100, 0, 0.8);
+
+    #selectable, #corpus {
+      padding: 1em;
+      border: 1px solid lightgrey;
     }
+
     #parsed {
-      height: 15rem;
+      height: 15em;
       overflow: scroll;
+      background: #f8f8f8;
+      color: #666666;
+      resize: vertical;
     }
   </style>
+  <script src="bundle.js"></script>
 
 Review comment:
   Safe to toss an `async` attribute on this if you're gonna move it up to head.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-annotator] Treora commented on a change in pull request #68: Tweak demo style & text

Posted by GitBox <gi...@apache.org>.

Treora commented on a change in pull request #68: Tweak demo style & text
URL: https://github.com/apache/incubator-annotator/pull/68#discussion_r399812587
 
 

 ##########
 File path: web/demo/index.html
 ##########
 @@ -18,65 +18,90 @@
 -->
 <!doctype html>
 <html>
+<head>
   <meta charset="utf-8">
   <meta http-equiv="X-UA-Compatible" content="IE=edge">
   <meta name="viewport" content="width=device-width, initial-scale=1">
   <title>Apache Annotator (incubating) demo</title>
-  <link rel="stylesheet" href="https://unpkg.com/awsm.css/dist/awsm.min.css">
+  <link rel="stylesheet" href="../style.css"/>
   <style>
-    blockquote {
-      font-style: italic;
-    }
     a[href^="#selector"]:before {
-      content: '📌';
-      font-size: 75%;
+      content: '📌 ';
     }
-    mark {
-      background-color: rgba(255, 255, 0, 0.5);
-      outline: 0.1px solid rgba(255, 100, 0, 0.8);
+
+    #selectable, #corpus {
+      padding: 1em;
+      border: 1px solid lightgrey;
     }
+
     #parsed {
-      height: 15rem;
+      height: 15em;
       overflow: scroll;
+      background: #f8f8f8;
+      color: #666666;
+      resize: vertical;
     }
   </style>
+  <script src="bundle.js"></script>
 
 Review comment:
   Good point; I made it `defer` instead, because with `async` we would have to check for the race condition (it could miss the `DOMContentLoaded` event).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services