You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/09/01 07:04:00 UTC

[jira] [Commented] (HDFS-16721) Improve the check code of the important configuration item “dfs.client.socket-timeout”.

    [ https://issues.apache.org/jira/browse/HDFS-16721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17598766#comment-17598766 ] 

ASF GitHub Bot commented on HDFS-16721:
---------------------------------------

Likkey closed pull request #4713: HDFS-16721.Improve the check code of the important configuration item “dfs.client.socket-timeout”.
URL: https://github.com/apache/hadoop/pull/4713




> Improve the check code of the important configuration item “dfs.client.socket-timeout”.
> ---------------------------------------------------------------------------------------
>
>                 Key: HDFS-16721
>                 URL: https://issues.apache.org/jira/browse/HDFS-16721
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: dfsclient
>    Affects Versions: 3.1.3
>         Environment: Linux version 4.15.0-142-generic (buildd@lgw01-amd64-039) (gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.12))
> java version "1.8.0_162"
> Java(TM) SE Runtime Environment (build 1.8.0_162-b12)
> Java HotSpot(TM) 64-Bit Server VM (build 25.162-b12, mixed mode)
>            Reporter: Jingxuan Fu
>            Assignee: Jingxuan Fu
>            Priority: Major
>              Labels: pull-request-available
>
> "dfs.client.socket-timeout" as the default timeout value for all sockets is applied in multiple places, it is a configuration item with significant impact, but the value of this configuration item is not checked in the source code and cannot be corrected in time when it is set to an abnormal value, which affects the normal use of the program.
> {code:java}
> <property>
>   <name>dfs.client.socket-timeout</name>
>   <value>60000</value>
>   <description>
>     Default timeout value in milliseconds for all sockets.
>   </description>
> </property>{code}
> So I used Precondition.checkArgument() to refine the code for checking this configuration item.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org