You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/21 16:01:02 UTC
[jira] [Commented] (METRON-580) Remove hard-coded Metron version
from Ambari MPack code
[ https://issues.apache.org/jira/browse/METRON-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15683940#comment-15683940 ]
ASF GitHub Bot commented on METRON-580:
---------------------------------------
GitHub user mmiklavc opened a pull request:
https://github.com/apache/incubator-metron/pull/364
Metron-580: Remove hard-coded Metron version from Ambari MPack code
This PR addresses https://issues.apache.org/jira/browse/METRON-580
The purpose here is to keep us from having to grep for version numbers in the MPack code the next time we bump the Metron version number. The change sets up a "CURRENT" version directory for the mpack code. The Maven Assembly plugin is then used to perform two operations: token replacement in source files, and movement of source files from CURRENT -> METRON VERSION in the final packaging layout.
**Testing**
Follow install instructions here - https://www.evernote.com/shard/s530/sh/c5551fbd-0ac1-4861-89ce-9c5e37065c52/b13e05f39eaac1a6
**Note** - if you are using Z shell, there is some wonkiness with the ambari docker stuff. Run this using Bash and you should be ok.
Make sure you start any sensors *last* to ensure the install goes smoothly in a local dev machine. For this change and test, I only started up the bro sensor.
I also modified the sensor-test-mode yaf task to include "ignore_errors: yes" - there appears to be an issue with Ansible wrt OS'es with systemd - https://github.com/ansible/ansible-modules-core/issues/915
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/incubator-metron METRON-580
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/364.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #364
----
commit cc1741bf48528fda629bd0c65f6a3bb5d82899d6
Author: Michael Miklavcic <mi...@gmail.com>
Date: 2016-11-16T17:39:54Z
Change to use assembly plugin for version revving
commit 5c3be8846b9a543cacaec05f1c73b5fe94c191ec
Author: Michael Miklavcic <mi...@gmail.com>
Date: 2016-11-21T15:42:56Z
METRON-580: Remove hard-coded Metron version from Ambari MPack code
----
> Remove hard-coded Metron version from Ambari MPack code
> -------------------------------------------------------
>
> Key: METRON-580
> URL: https://issues.apache.org/jira/browse/METRON-580
> Project: Metron
> Issue Type: Improvement
> Reporter: Michael Miklavcic
>
> We currently have the Metron version hard-coded in the Ambari MPack code. For instance "metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/0.3.0". This Jira addresses removing this hard-coded version info and making it based on the master project version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)