You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/03 21:19:24 UTC

[GitHub] [tvm] vinx13 opened a new pull request, #12300: [TIR] Add DeclBuffer IR node and functors

vinx13 opened a new pull request, #12300:
URL: https://github.com/apache/tvm/pull/12300

   This PR is part of https://github.com/apache/tvm/issues/11627. It added the IR node `DeclBufferNode`, IR functors and TVMScript printer / parser.
   
   cc @tqchen @Lunderberg @Hzfengsy @junrushao1994 @wrongtest-intellif 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] cyx-6 commented on pull request #12300: [TIR] Add DeclBuffer IR node and functors

Posted by GitBox <gi...@apache.org>.
cyx-6 commented on PR #12300:
URL: https://github.com/apache/tvm/pull/12300#issuecomment-1205881480

   > CC @cyx-6 please review for potential TVMScript syntactic/semantic change :-)
   
   LGTM. New parser is compatible with this change, and will be updated soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao1994 commented on pull request #12300: [TIR] Add DeclBuffer IR node and functors

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #12300:
URL: https://github.com/apache/tvm/pull/12300#issuecomment-1205705281

   CC @cyx-6 please review for potential TVMScript syntax change :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] vinx13 commented on pull request #12300: [TIR] Add DeclBuffer IR node and functors

Posted by GitBox <gi...@apache.org>.
vinx13 commented on PR #12300:
URL: https://github.com/apache/tvm/pull/12300#issuecomment-1206708084

   yes. `T.buffer_decl` will be deprecated in the future


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao1994 commented on a diff in pull request #12300: [TIR] Add DeclBuffer IR node and functors

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on code in PR #12300:
URL: https://github.com/apache/tvm/pull/12300#discussion_r939043264


##########
src/target/source/codegen_c.cc:
##########
@@ -29,6 +29,7 @@
 
 #include "../../arith/pattern_match.h"
 #include "codegen_params.h"
+#include "tvm/tir/stmt.h"

Review Comment:
   nit
   
   ```suggestion
   #include <tvm/tir/stmt.h>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] vinx13 merged pull request #12300: [TIR] Add DeclBuffer IR node and functors

Posted by GitBox <gi...@apache.org>.
vinx13 merged PR #12300:
URL: https://github.com/apache/tvm/pull/12300


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org