You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "Stas Levin (JIRA)" <ji...@apache.org> on 2017/08/30 13:00:02 UTC

[jira] [Commented] (BEAM-2825) Improve readability of SparkGroupAlsoByWindowViaWindowSet

    [ https://issues.apache.org/jira/browse/BEAM-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147183#comment-16147183 ] 

Stas Levin commented on BEAM-2825:
----------------------------------

[BEAM-2669] could possibly introduce minor changes to the {{SparkGroupAlsoByWindowViaWindowSet}} class, so it's best if the PR for [BEAM-2825] is rebased off the one for [BEAM-2669].

> Improve readability of SparkGroupAlsoByWindowViaWindowSet
> ---------------------------------------------------------
>
>                 Key: BEAM-2825
>                 URL: https://issues.apache.org/jira/browse/BEAM-2825
>             Project: Beam
>          Issue Type: Task
>          Components: runner-spark
>            Reporter: Stas Levin
>            Assignee: Stas Levin
>            Priority: Minor
>
> It would be nice to address some of the readability issues one can currently observe in {{SparkGroupAlsoByWindowViaWindowSet}}, in particular:
> # Long methods
> # Long anonymous classes



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)