[GitHub] [lucene-solr] cpoerschke commented on pull request #2196: SOLR-15071: Fix ArrayIndexOutOfBoundsException in contrib/ltr SolrFeatureScorer

[GitBox <gi...@apache.org>]

cpoerschke commented on pull request #2196:
URL: https://github.com/apache/lucene-solr/pull/2196#issuecomment-758599976


   > ... Note that a plausible alternative is to simply not specify it and thus inherit the null-returning implementation from the Scorer. ...
   
   Good idea. Done.
   
   > Can you please include a simple test that exposes the problem? ...
   
   I've now included in the branch (and then reverted) the scripted version of the steps-to-reproduce with the .json files from the JIRA plus selective debug logging. It does not reliably reproduce with the script, about 2-of-10 or 3-of-11 runs hit the issue. Here's the debug logging output:
   
   ```
   org.apache.lucene.search.MinShouldMatchSumScorer@5127aa0a cpoerschke debug: constructor freq = 6
   org.apache.lucene.search.MinShouldMatchSumScorer@5127aa0a cpoerschke debug: constructor minShouldMatch = 5
   org.apache.lucene.search.MinShouldMatchSumScorer@5127aa0a cpoerschke debug: setDocAndFreq caller = TwoPhaseIterator.advance
   org.apache.lucene.search.MinShouldMatchSumScorer@5127aa0a cpoerschke debug: score
   org.apache.lucene.search.MinShouldMatchSumScorer@5127aa0a cpoerschke debug: updateFreq freq = 1
   org.apache.lucene.search.MinShouldMatchSumScorer@5127aa0a cpoerschke debug: updateFreq minShouldMatch = 5
   org.apache.lucene.search.MinShouldMatchSumScorer@5127aa0a cpoerschke debug: updateFreq (freq >= minShouldMatch) = false
   ```
   
   Note that `minShouldMatch = 5` matches the `mm=5` in the feature and that the `q` and `efi.term` is `"husa%20cu%20tastatura%20tableta%2010%20inch` which is `"husa cu tastatura tableta 10 inch"` i.e. 6 terms matching the `freq = 6`.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org