You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "nvazquez (via GitHub)" <gi...@apache.org> on 2023/08/16 01:54:00 UTC

[GitHub] [cloudstack] nvazquez opened a new pull request, #7872: UI add domain account to register tmpl

nvazquez opened a new pull request, #7872:
URL: https://github.com/apache/cloudstack/pull/7872

   ### Description
   
   This PR allows passing an optional domain and accout to the registerTemplate API (only possible to pass these parameters through the API)
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   - Register a template as an admin to another account in other domain -> verify domainid and account parameters are passed correctly
   - Register a template as an admin without setting any domain or account -> verify domainid and account parameters are not passed
   - Login as a user, verify the domain dropdown is not displayed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7872: UI: Add domain and account fields to Register/Upload Template/ISO view

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1681899855

   Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6815


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] codecov[bot] commented on pull request #7872: UI: Add domain and account fields to Register Template view

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1679882341

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7872?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#7872](https://app.codecov.io/gh/apache/cloudstack/pull/7872?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5c02acc) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/5559668f126d317de0eb1bddc14eccad38564638?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5559668) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #7872   +/-   ##
   =========================================
     Coverage     14.39%   14.39%           
   - Complexity    10081    10082    +1     
   =========================================
     Files          2747     2747           
     Lines        258936   258936           
     Branches      40322    40322           
   =========================================
   + Hits          37263    37265    +2     
   + Misses       216860   216859    -1     
   + Partials       4813     4812    -1     
   ```
   
   
   [see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7872/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7872: UI: Add domain and account fields to Register/Upload Template/ISO view

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1680693933

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7872 (QA-JID-148)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7872: UI: Add domain and account fields to Register/Upload Template/ISO view

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1680661553

   @nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #7872: UI: Add domain and account fields to Register/Upload Template/ISO view

Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1680659976

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7872: UI: Add domain and account fields to Register/Upload Template/ISO view

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1681768761

   @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on pull request #7872: UI: Add domain and account fields to Register Template view

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1680189232

   > @nvazquez should similar fields be added in the ISO form?
   
   make sense
   cc @nvazquez 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7872: UI: Add domain and account fields to Register Template view

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1680178583

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7872 (QA-JID-147)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache merged pull request #7872: UI: Add domain and account fields to Register/Upload Template/ISO view

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache merged PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #7872: UI: Add domain and account fields to Register Template view

Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1680653317

   Thanks @shwstppr @weizhouapache - I have added them to the Register/Upload ISO view as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on pull request #7872: UI: Add domain and account fields to Register/Upload Template/ISO view

Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1680957473

   Done thanks @weizhouapache
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7872: UI: Add domain and account fields to Register/Upload Template/ISO view

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1681787600

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7872 (QA-JID-150)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #7872: UI: Add domain and account fields to Register/Upload Template/ISO view

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1681767426

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7872: UI: Add domain and account fields to Register/Upload Template/ISO view

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1680963854

   @nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] shwstppr commented on pull request #7872: UI: Add domain and account fields to Register Template view

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1679899057

   @nvazquez should similar fields be added in the ISO form?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7872: UI: Add domain and account fields to Register Template view

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1680157529

   @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #7872: UI: Add domain and account fields to Register Template view

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1680156603

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] weizhouapache commented on pull request #7872: UI: Add domain and account fields to Register/Upload Template/ISO view

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1680921885

   @nvazquez 
   can you fix the conflicts ? thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #7872: UI: Add domain and account fields to Register/Upload Template/ISO view

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7872:
URL: https://github.com/apache/cloudstack/pull/7872#issuecomment-1680988962

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7872 (QA-JID-149)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org