You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/20 16:19:15 UTC
[GitHub] [airflow] mirobertod opened a new pull request #18379: add extraContainers for migrateDatabaseJob
mirobertod opened a new pull request #18379:
URL: https://github.com/apache/airflow/pull/18379
Hello,
I'd like to add `extraContainers` for `migrateDatabaseJob`, likewise what has been done for the other pods.
One use case might be to use a sidecar container as a proxy for the database, for instance [`cloudsql-proxy`](https://github.com/GoogleCloudPlatform/cloudsql-proxy)
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mirobertod commented on pull request #18379: add extraContainers for migrateDatabaseJob
Posted by GitBox <gi...@apache.org>.
mirobertod commented on pull request #18379:
URL: https://github.com/apache/airflow/pull/18379#issuecomment-993779240
> Hey @mirobertod , I came across this PR and it seems you are trying to do like what I do, to lunch cloud-sql sidecar in the airflow migration database jobs. However, how did you manage to terminate the cloud-sql proxy when the `run-airflow-migrations` has been terminated?
Hi @omarsmak , I don't exactly remember if I got stuck with the same problem, but my current solution is to use the cloud SQL proxy as a service instead of sidecar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mirobertod commented on pull request #18379: add extraContainers for migrateDatabaseJob
Posted by GitBox <gi...@apache.org>.
mirobertod commented on pull request #18379:
URL: https://github.com/apache/airflow/pull/18379#issuecomment-924659386
The test failed says `Process completed with exit code 137.` Usually exit code 137 is about out of memory error.
Can we try to run the test again?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mirobertod commented on pull request #18379: add extraContainers for migrateDatabaseJob
Posted by GitBox <gi...@apache.org>.
mirobertod commented on pull request #18379:
URL: https://github.com/apache/airflow/pull/18379#issuecomment-924121933
> Some static checks failing
Should be fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18379: add extraContainers for migrateDatabaseJob
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18379:
URL: https://github.com/apache/airflow/pull/18379#issuecomment-924074140
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18379: add extraContainers for migrateDatabaseJob
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18379:
URL: https://github.com/apache/airflow/pull/18379#issuecomment-923076565
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18379: add extraContainers for migrateDatabaseJob
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18379:
URL: https://github.com/apache/airflow/pull/18379#issuecomment-924774720
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] omarsmak commented on pull request #18379: add extraContainers for migrateDatabaseJob
Posted by GitBox <gi...@apache.org>.
omarsmak commented on pull request #18379:
URL: https://github.com/apache/airflow/pull/18379#issuecomment-992701712
Hey @mirobertod , I came across this PR and it seems you are trying to do like what I do, to lunch cloud-sql sidecar in the airflow migration database jobs. However, how did you manage to terminate the cloud-sql proxy when the `run-airflow-migrations` has been terminated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18379: add extraContainers for migrateDatabaseJob
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18379:
URL: https://github.com/apache/airflow/pull/18379#issuecomment-924109958
Some static checks failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mirobertod commented on pull request #18379: add extraContainers for migrateDatabaseJob
Posted by GitBox <gi...@apache.org>.
mirobertod commented on pull request #18379:
URL: https://github.com/apache/airflow/pull/18379#issuecomment-923733822
> Could you please add unit tests for those ?
Sure, test added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18379: add extraContainers for migrateDatabaseJob
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18379:
URL: https://github.com/apache/airflow/pull/18379#issuecomment-923434724
Could you please add unit tests for those ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18379: add extraContainers for migrateDatabaseJob
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18379:
URL: https://github.com/apache/airflow/pull/18379#issuecomment-924774447
For the future - Just rebase and push the change - there is no way in GH to rebuild single test. And yeah 139 is intermittent out of memor so we can merge that one without doing it as all the other tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18379: add extraContainers for migrateDatabaseJob
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18379:
URL: https://github.com/apache/airflow/pull/18379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #18379: add extraContainers for migrateDatabaseJob
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #18379:
URL: https://github.com/apache/airflow/pull/18379#issuecomment-924774447
For the future - Just rebase and push the change - there is no way in GH to rebuild single test. And yeah 137 is intermittent out of memory so we can merge that one without doing it as all the other tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org