[jira] [Created] (MINIFICPP-1271) Disable linter check for [build/include_subdir]

["Adam Hunyadi (Jira)" <ji...@apache.org>]

Adam Hunyadi created MINIFICPP-1271:
---------------------------------------

             Summary: Disable linter check for [build/include_subdir]
                 Key: MINIFICPP-1271
                 URL: https://issues.apache.org/jira/browse/MINIFICPP-1271
             Project: Apache NiFi MiNiFi C++
          Issue Type: Task
    Affects Versions: 0.7.0
            Reporter: Adam Hunyadi
            Assignee: Adam Hunyadi
             Fix For: 1.0.0


*Background:*

Including some of our dependencies produce linter errors, both by having them included int ""-s and <>-s. For example:
{code:c++}
#include "concurrentqueue.h"
{code}
{quote}error cpplint Include the directory when naming .h files [build/include_subdir] [4]
{quote}
{code:c++}
#include <concurrentqueue.h>
{code}
{quote}error cpplint Found C system header after C++ system header. Should be: ExampleHeader.h, c system, c++ system, other. [build/include_order] [4]
{quote}
The issue is that the google styleguide expects all dependency headers included in subfolders, while our project does not have this dependency.

*Proposal:*

As we do not gain much by enforcing a subfolder rule for every header file included, we agreed to disable this linter rule globally on the project.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)