[GitHub] [phoenix] gjacoby126 commented on a diff in pull request #1606: PHOENIX-6955 The value of region metric--lastMajorCompactionAge is wrong，when the hfile is buckload file

["gjacoby126 (via GitHub)" <gi...@apache.org>]

gjacoby126 commented on code in PR #1606:
URL: https://github.com/apache/phoenix/pull/1606#discussion_r1198247633


##########
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/MultiHfileOutputFormat.java:
##########
@@ -265,7 +265,8 @@ private WriterLength getNewWriter(final String tableName , byte[] family, Config
                                         .withBytesPerCheckSum(CompatUtil.getBytesPerChecksum(conf))
                                         .withBlockSize(blockSize)
                                         .withDataBlockEncoding(encoding)
-                                        .withCellComparator(CellComparatorImpl.COMPARATOR);
+                                        .withCellComparator(CellComparatorImpl.COMPARATOR)
+                                        .withCreateTime(System.currentTimeMillis());;

Review Comment:
   This should probably be EnvironmentEdgeManager.currentTime() so that tests can override the timestamp correctly. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org