You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/05/18 12:01:04 UTC

[GitHub] [zookeeper] symat opened a new pull request, #1879: ZOOKEEPER-4544: sync ant and maven dependency versions on branch-3.5

symat opened a new pull request, #1879:
URL: https://github.com/apache/zookeeper/pull/1879

   Our default build system is maven on branch-3.5. However, ant is still
   supported (and in some cases, like zkpython, one can not even build on
   branch-3.5 unless builds zookeeper-server with ant).
   
   Currently if one builds ZooKeeper with ant, she/he will end up having
   different dependency versions compared to maven (including log4j instead
   of reload4j).
   
   After this patch, if one executs the following commands:
   
   ```
   git clean -xdf
   ant clean compile compile-native
   cd zookeeper-contrib/zookeeper-contrib-zkpython/
   ant compile
   ant test
   ```
   
   then:
   
   - zkpython built / tested successfully
   - the zookeeper server related 3pp libs in build/libs folder
     should be up-to-date and should not contain CVEs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ZOOKEEPER-4544: sync ant and maven dependencies on branch-3.5 [zookeeper]

Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw closed pull request #1879: ZOOKEEPER-4544: sync ant and maven dependencies on branch-3.5
URL: https://github.com/apache/zookeeper/pull/1879


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1879: ZOOKEEPER-4544: sync ant and maven dependency versions on branch-3.5

Posted by GitBox <gi...@apache.org>.
symat commented on PR #1879:
URL: https://github.com/apache/zookeeper/pull/1879#issuecomment-1129921162

   on 3.6+, zkpython can be built without building zookeeper-server or zookeeper-client using ant. This was fixed in ZOOKEEPER-3567 (which can not be backported to branch-3.5, as we have no SSL support in zookeeper-client-c there)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1879: ZOOKEEPER-4544: sync ant and maven dependency versions on branch-3.5

Posted by GitBox <gi...@apache.org>.
symat commented on PR #1879:
URL: https://github.com/apache/zookeeper/pull/1879#issuecomment-1129922952

   @eolivelli , @anmolnar , @nkalmar can you take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1879: ZOOKEEPER-4544: sync ant and maven dependencies on branch-3.5

Posted by GitBox <gi...@apache.org>.
symat commented on PR #1879:
URL: https://github.com/apache/zookeeper/pull/1879#issuecomment-1129993008

   thanks for the review, merging it now to branch-3.5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ZOOKEEPER-4544: sync ant and maven dependencies on branch-3.5 [zookeeper]

Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #1879:
URL: https://github.com/apache/zookeeper/pull/1879#issuecomment-2339831582

   Close as already merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org