You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Henning Schmiedehausen <he...@schmiedehausen.org> on 2015/02/18 02:26:00 UTC

Review Request 31142: MESOS-2364 - Docker containerizer should pull every time if image tag is ":latest"

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31142/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-2364
    https://issues.apache.org/jira/browse/MESOS-2364


Repository: mesos


Description
-------

The "latest" tag for a docker image denominates the newest or most
recent version of a docker image. So the docker containerizer should
pull every time from the registry if the "latest" tag is encountered
to ensure that the most recent version is used.


Diffs
-----

  src/docker/docker.hpp 3ebbc1f82ac388c4d348417ae33ccc2a56ad3f28 
  src/docker/docker.cpp 94f16e701f89367b599f0bd8f44c2f1de21a8e20 

Diff: https://reviews.apache.org/r/31142/diff/


Testing
-------


Thanks,

Henning Schmiedehausen


Re: Review Request 31142: MESOS-2364 - Docker containerizer should pull every time if image tag is ":latest"

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31142/#review72906
-----------------------------------------------------------


Patch looks great!

Reviews applied: [31142]

All tests passed.

- Mesos ReviewBot


On Feb. 18, 2015, 1:25 a.m., Henning Schmiedehausen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31142/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 1:25 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2364
>     https://issues.apache.org/jira/browse/MESOS-2364
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The "latest" tag for a docker image denominates the newest or most
> recent version of a docker image. So the docker containerizer should
> pull every time from the registry if the "latest" tag is encountered
> to ensure that the most recent version is used.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 3ebbc1f82ac388c4d348417ae33ccc2a56ad3f28 
>   src/docker/docker.cpp 94f16e701f89367b599f0bd8f44c2f1de21a8e20 
> 
> Diff: https://reviews.apache.org/r/31142/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Henning Schmiedehausen
> 
>