[GitHub] [trafficcontrol] rob05c opened a new pull request #3646: Fix Monitor Thresholds

[GitBox <gi...@apache.org>]

rob05c opened a new pull request #3646: Fix Monitor Thresholds
URL: https://github.com/apache/trafficcontrol/pull/3646
 
 
   This fixes the Monitor racing and the health poll marking Available
   caches which were marked Unavailable by the Stat poll.
   
   There was already logic to prevent that, but it wasn't accounting
   for the Calculated stats, so the Health poll didn't check Calculated
   stats for thresholds, but it does "have" those stats, so it thought
   it could mark them available again.
   
   This fixes the Health poll to also check thresholds for Calculated
   stats, which not only fixes the race, but makes thresholds be
   marked up and down faster with the quicker Health poll.
   
   - [ ] This PR is not related to any Issue 
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Monitor
   
   ## What is the best way to verify this PR?
   
   Set low availableKbps thresholds, run the monitor, verify in the Event Log and Cache States that caches are marked unavailable from kbps threshold, verify health poll does not mark caches that remain above the threshold as available, and that caches remain Unavailable (unless they drop below the threshold).
   
   ## If this is a bug fix, what versions of Traffic Ops are affected?
   
   - 2.2
   - 3.0.0
   - 3.0.1
   
   ## The following criteria are ALL met by this PR
   
   - [ ] This PR includes tests OR I have explained why tests are unnecessary
   - [ ] This PR includes documentation OR I have explained why documentation is unnecessary
   - [ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [ ] This PR includes any and all required license headers
   - [ ] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [ ] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services