You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2023/08/18 04:22:29 UTC

[camel] branch camel-3.x updated: CAMEL-19758: netty-http in proxy mode generates IllegalReferenceCountException for every success request. (#11146)

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch camel-3.x
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/camel-3.x by this push:
     new 6cb45ab99a6 CAMEL-19758: netty-http in proxy mode generates IllegalReferenceCountException for every success request. (#11146)
6cb45ab99a6 is described below

commit 6cb45ab99a6f48f4511560ac6a67aa4ec66b6718
Author: Luigi De Masi <55...@users.noreply.github.com>
AuthorDate: Fri Aug 18 06:21:34 2023 +0200

    CAMEL-19758: netty-http in proxy mode generates IllegalReferenceCountException for every success request. (#11146)
---
 .../apache/camel/component/netty/http/DefaultNettyHttpBinding.java   | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/DefaultNettyHttpBinding.java b/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/DefaultNettyHttpBinding.java
index f3785da9199..d35ca1cad8f 100644
--- a/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/DefaultNettyHttpBinding.java
+++ b/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/DefaultNettyHttpBinding.java
@@ -108,7 +108,10 @@ public class DefaultNettyHttpBinding implements NettyHttpBinding, Cloneable {
             exchange.adapt(ExtendedExchange.class).addOnCompletion(new SynchronizationAdapter() {
                 @Override
                 public void onDone(Exchange exchange) {
-                    ReferenceCountUtil.release(request.content());
+                    if (request.content().refCnt() > 0) {
+                        LOG.debug("Releasing Netty HttpResponse ByteBuf");
+                        ReferenceCountUtil.release(request.content());
+                    }
                 }
             });
         } else {