[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7713: Document crate feature flags

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #7713:
URL: https://github.com/apache/arrow-datafusion/pull/7713#discussion_r1342125519


##########
docs/source/user-guide/example-usage.md:
##########
@@ -187,10 +187,6 @@ DataFusion is designed to be extensible at all points. To that end, you can prov
 - [x] User Defined `LogicalPlan` nodes
 - [x] User Defined `ExecutionPlan` nodes
 
-## Rust Version Compatibility

Review Comment:
   moved to the main landing page



##########
datafusion/core/Cargo.toml:
##########
@@ -39,8 +39,8 @@ avro = ["apache-avro", "num-traits", "datafusion-common/avro"]
 backtrace = ["datafusion-common/backtrace"]
 compression = ["xz2", "bzip2", "flate2", "zstd", "async-compression"]
 crypto_expressions = ["datafusion-physical-expr/crypto_expressions", "datafusion-optimizer/crypto_expressions"]
-default = ["crypto_expressions", "encoding__expressions", "regex_expressions", "unicode_expressions", "compression"]

Review Comment:
   Drive by fix: I believe the double `_` `_` is a typo that results in this feature always being on. This makes it so users can disable it if needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org