You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "rich7420 (via GitHub)" <gi...@apache.org> on 2025/11/08 06:00:33 UTC
[PR] fix: Rendered Templates not showing dictionary items in AF3 [airflow]
rich7420 opened a new pull request, #58071:
URL: https://github.com/apache/airflow/pull/58071
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
related: #57607
This PR reproduced and modified the error situation describing in the issue #57607 .
Before:
After:
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Rendered Templates not showing dictionary items in AF3 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #58071:
URL: https://github.com/apache/airflow/pull/58071#issuecomment-3623455320
Backported here: https://github.com/apache/airflow/pull/59176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Rendered Templates not showing dictionary items in AF3 [airflow]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #58071:
URL: https://github.com/apache/airflow/pull/58071#issuecomment-3510856590
@potiuk thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Rendered Templates not showing dictionary items in AF3 [airflow]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #58071:
URL: https://github.com/apache/airflow/pull/58071#issuecomment-3507502255
There is a unit test fails before the change and succeeds after.
I ran locally with the command. :
`uv run pytest airflow-core/tests/unit/models/test_renderedtifields.py::TestRenderedTaskInstanceFields::test_nested_dictionary_template_field_rendering -v`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Rendered Templates not showing dictionary items in AF3 [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #58071:
URL: https://github.com/apache/airflow/pull/58071#issuecomment-3617722619
I don't think it was backported. Marking for 3.1.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Rendered Templates not showing dictionary items in AF3 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #58071:
URL: https://github.com/apache/airflow/pull/58071#issuecomment-3623447461
Let's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Rendered Templates not showing dictionary items in AF3 [airflow]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #58071:
URL: https://github.com/apache/airflow/pull/58071#issuecomment-3507290548
@potiuk sure, thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Rendered Templates not showing dictionary items in AF3 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #58071:
URL: https://github.com/apache/airflow/pull/58071#discussion_r2507239376
##########
airflow-core/src/airflow/models/renderedtifields.py:
##########
@@ -51,6 +51,28 @@
from airflow.serialization.serialized_objects import SerializedBaseOperator
Review Comment:
Looks good - but I think you need to add a unit tests that fails before the change and succeeds after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Rendered Templates not showing dictionary items in AF3 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #58071:
URL: https://github.com/apache/airflow/pull/58071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org