You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/06 15:16:26 UTC
[GitHub] [flink] snuyanzin opened a new pull request, #21459: [hotfix] Replace deprecated Calcite's APIs
snuyanzin opened a new pull request, #21459:
URL: https://github.com/apache/flink/pull/21459
## What is the purpose of the change
1. `org.apache.calcite.sql.SqlCharStringLiteral#getNlsString` was made deprecated at
https://github.com/apache/calcite/commit/a1bdba6d79ac05ef227cdb15b7c044c6e0e54dfa#diff-de2027de5bcb4bbe94314c3414b63166ecd9537b437e08d39f6424c0f903c8fbR48
and as suggested in the same place
```
* @deprecated Use {@link #getValueAs getValueAs(NlsString.class)}
```
2. `org.apache.calcite.rex.RexSimplify#RexSimplify(RexBuilder, RelOptPredicateList, boolean, RexExecutor)` was made deprecated at https://issues.apache.org/jira/browse/CALCITE-2604
and it is recommended
```
* @deprecated Use methods with a {@link RexUnknownAs} argument, such as
* {@link #simplify(RexNode, RexUnknownAs)}. */
```
3. `org.apache.calcite.rel.core.AggregateCall#create(SqlAggFunction, boolean, boolean, boolean, List<Integer>, int, RelCollation, RelDataType, String)` was made deprecated at https://issues.apache.org/jira/browse/CALCITE-4483
now distinct keys should be specified
4 `org.apache.calcite.rel.core.Aggregate#Aggregate(RelOptCluster, RelTraitSet, RelNode, ImmutableBitSet, List<ImmutableBitSet>, List<AggregateCall>)` was deprecated at https://issues.apache.org/jira/browse/CALCITE-3723
now hints should be specified
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
- The serializers: ( no )
- The runtime per-record code paths (performance sensitive): ( no )
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
- The S3 file system connector: ( no)
## Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #21459: [hotfix] Replace deprecated Calcite's APIs
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #21459:
URL: https://github.com/apache/flink/pull/21459#issuecomment-1342704458
Usages in these classes
`org.apache.flink.table.planner.delegation.hive.HiveParserUtils`
`org.apache.flink.table.planner.calcite.RelTimeIndicatorConverter`
`org.apache.flink.table.planner.plan.rules.logical.FlinkAggregateExpandDistinctAggregatesRule`
`org.apache.flink.table.planner.codegen.MatchCodeGenerator`
`org.apache.flink.table.planner.plan.rules.logical.AggregateReduceGroupingRule`
`org.apache.flink.table.planner.plan.utils.AggregateUtil`
`org.apache.flink.table.planner.plan.metadata.FlinkRelMdHandlerTestBase`
probably could be initially missed because of different args
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #21459: [hotfix] Replace deprecated Calcite's APIs
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #21459:
URL: https://github.com/apache/flink/pull/21459#issuecomment-1341241270
Created FLINK-30328 to cover the test failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #21459: [hotfix] Replace deprecated Calcite's APIs
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #21459:
URL: https://github.com/apache/flink/pull/21459#issuecomment-1342681925
Yeah, grepping/idea file search is the best way to identify usages for something like that. But all the occurrences of `AggregateCall#create` I found looked legit. I'm curious what you sitll found...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #21459: [hotfix] Replace deprecated Calcite's APIs
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #21459:
URL: https://github.com/apache/flink/pull/21459#issuecomment-1342207355
Thanks for the feedback. I updated the rest of `AggregateCall.create` and also updated some more deprecated methods (updated in description) `org.apache.calcite.rex.RexWindowBound#create`, `org.apache.calcite.rel.RelCollationImpl#of(org.apache.calcite.rel.RelFieldCollation...)` and `org.apache.calcite.rel.core.Window.RexWinAggCall#RexWinAggCall(SqlAggFunction, RelDataType, List<RexNode>, int, boolean)`
About `RexSimplify` yes it should not be updated. It is a copy of Calcite's `RexSimplify` with one change in it and should be supported synced with Calcite's version while update. It should be removed once a corresponding jira issue will be fixed
https://github.com/apache/flink/blob/e6215d4f7ede96f1225921f2b0f322c87a5040cd/flink-table/flink-table-planner/src/main/java/org/apache/calcite/rex/RexSimplify.java#L69-L73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #21459: [hotfix] Replace deprecated Calcite's APIs
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #21459:
URL: https://github.com/apache/flink/pull/21459#issuecomment-1344011936
Looks like the previous one failed with unrelated Pulsar issue [1].
the last run is ok
[1] https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=43809&view=logs&j=af184cdd-c6d8-5084-0b69-7e9c67b35f7a&s=ae4f8708-9994-57d3-c2d7-b892156e7812&t=160c9ae5-96fd-516e-1c91-deb81f59292a&l=14255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #21459: [hotfix] Replace deprecated Calcite's APIs
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #21459:
URL: https://github.com/apache/flink/pull/21459#issuecomment-1343100225
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #21459: [hotfix] Replace deprecated Calcite's APIs
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #21459:
URL: https://github.com/apache/flink/pull/21459#issuecomment-1342675500
Looks like Idea(or just my set up of it) is kind of weird in finding usages... with help of full-text search I noticed several more missing `AggregateCall#create`
I'm going to push one more commit once this finishes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21459: [hotfix] Replace deprecated Calcite's APIs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21459:
URL: https://github.com/apache/flink/pull/21459#issuecomment-1339545457
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "39d8a1b17ff16cae0ef83b8538e19a1a5346f88a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "39d8a1b17ff16cae0ef83b8538e19a1a5346f88a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 39d8a1b17ff16cae0ef83b8538e19a1a5346f88a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp merged pull request #21459: [hotfix] Replace deprecated Calcite's APIs
Posted by GitBox <gi...@apache.org>.
XComp merged PR #21459:
URL: https://github.com/apache/flink/pull/21459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #21459: [hotfix] Replace deprecated Calcite's APIs
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #21459:
URL: https://github.com/apache/flink/pull/21459#issuecomment-1341241595
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #21459: [hotfix] Replace deprecated Calcite's APIs
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #21459:
URL: https://github.com/apache/flink/pull/21459#issuecomment-1342839741
The failure is related to https://issues.apache.org/jira/browse/FLINK-29755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org