You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/23 13:29:38 UTC

[GitHub] [pulsar] BewareMyPower commented on pull request #11749: [Broker] Handle NPE and memory leak when full key range isn't covered with active consumers

BewareMyPower commented on pull request #11749:
URL: https://github.com/apache/pulsar/pull/11749#issuecomment-903770001


   I approved first but have a suggestion that is not required. Should we also update the JavaDoc of `select` method to note that it could return null? Though the better practice may be using `@NonNull` annotation for those methods that should never return null, I found this annotation is not widely use in current source code.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org