[GitHub] [incubator-seatunnel] kezhenxu94 commented on a change in pull request #1210: [Feature][CI] Automatically generate LICENSE

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #1210:
URL: https://github.com/apache/incubator-seatunnel/pull/1210#discussion_r801532476



##########
File path: pom.xml
##########
@@ -789,6 +790,51 @@
                     <artifactId>build-helper-maven-plugin</artifactId>
                     <version>${maven-helper-plugin.version}</version>
                 </plugin>
+
+                <plugin>
+                    <groupId>org.codehaus.mojo</groupId>
+                    <artifactId>license-maven-plugin</artifactId>
+                    <version>${maven-license-maven-plugin}</version>
+                    <executions>
+                        <execution>
+                            <id>download</id>
+                            <goals>
+                                <goal>download-licenses</goal>
+                            </goals>
+                        </execution>
+                    </executions>
+                    <configuration>
+                        <outputDirectory>${project.basedir}/seatunnel-dist/target/</outputDirectory>
+                        <thirdPartyFilename>THIRD-PARTY.txt</thirdPartyFilename>
+                        <sortArtifactByName>true</sortArtifactByName>
+                        <useMissingFile>false</useMissingFile>
+                        <addJavaLicenseAfterPackage>true</addJavaLicenseAfterPackage>
+                    </configuration>
+                </plugin>
+
+                <plugin>
+                    <groupId>org.codehaus.mojo</groupId>
+                    <artifactId>exec-maven-plugin</artifactId>
+                    <version>${exec-maven-plugin.version}</version>
+                    <executions>
+                        <execution>
+                            <id>license</id>
+                            <phase>package</phase>
+                            <goals>
+                                <goal>exec</goal>
+                            </goals>
+                            <configuration>

Review comment:
       I suggest not to execute this goal by default, for some reasons:
   
   - end users don't need to run this python script if they only want to download the source codes and build the package themselves
   - the Python script will fail if the users don't have a correct Python version and dependency modules installed, the script is not vanilla Python script right?

##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -937,13 +819,34 @@ The text of each license is also included at licenses/LICENSE-[project].txt.
      (Mozilla Public License Version 2.0) jamon-runtime (org.jamon:jamon-runtime:2.4.1 - http://www.jamon.org/jamon-java-parent/jamon-runtime/)
      (Mozilla Public License, Version 2.0) Mozilla Rhino (org.mozilla:rhino:1.7.11 - https://developer.mozilla.org/en/Rhino)
 
+
 ========================================================================
 Unicode License
 ========================================================================
 
 The following components are provided under the Unicode License. See project link for details.
 The text of each license is also included at licenses/LICENSE-[project].txt.
 
-     (Unicode/ICU License) ICU4J (com.ibm.icu:icu4j:60.2 - http://icu-project.org/)
      (Unicode/ICU License) ICU4J Charset Provider (com.ibm.icu:icu4j-charset:60.2 - http://icu-project.org/)
      (Unicode/ICU License) ICU4J Locale Service Provider (com.ibm.icu:icu4j-localespi:60.2 - http://icu-project.org/)
+
+
+========================================================================
+Other License
+========================================================================
+
+The following components are provided under some minority Licenses. See project link for details.
+The text of each license is also included at licenses/LICENSE-[project].txt.
+
+     (Unknown license) Antlr 3.4 Runtime (org.antlr:antlr-runtime:3.4 - http://www.antlr.org)
+     (Unknown license) commons-beanutils (commons-beanutils:commons-beanutils:1.7.0 - no url defined)
+     (Unknown license) commons-pool (commons-pool:commons-pool:1.5.4 - no url defined)
+     (Unknown license) Java Transaction API (javax.transaction:jta:1.1 - http://java.sun.com/products/jta)
+     (Unknown license) jsp-api (javax.servlet.jsp:jsp-api:2.1 - no url defined)
+     (APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 - https://msgpack.org/)
+     (Unknown license) oro (oro:oro:2.0.8 - no url defined)
+     (The Go license) re2j (com.google.re2j:re2j:1.1 - http://github.com/google/re2j)
+     (Unknown license) servlet-api (javax.servlet:servlet-api:2.5 - no url defined)
+     (Unknown license) sigar (org.hyperic:sigar:1.6.5.132 - no url defined)

Review comment:
       These should be recognized by human beings, `Other License` is a potential license risk to me, as they are `Unknown`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org