You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/16 10:51:47 UTC

[GitHub] [airflow] potiuk opened a new pull request #7430: [AIRFLOW-6816] Separated out common utils

potiuk opened a new pull request #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Simplified common functions in breeze scripts

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Simplified common functions in breeze scripts
URL: https://github.com/apache/airflow/pull/7430#discussion_r379917315
 
 

 ##########
 File path: scripts/ci/ci_before_install.sh
 ##########
 @@ -15,25 +15,12 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+set -x
 
 Review comment:
   left it on purpose. ci_before install is folded in Travis so it's ok to get more information and sometimes it's easier to debug it this way

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7430: [AIRFLOW-6816] Separated out common utils

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430#issuecomment-586699262
 
 
   > You've removed `set -uo pipefail` from most pre_commit_* files, why's that?
   
   Has not finished it yet - now all the pre_commits are sourcing the original scripts so the -euo pipefail comes from _script_init.sh

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430#discussion_r379893711
 
 

 ##########
 File path: .pre-commit-config.yaml
 ##########
 @@ -285,14 +285,14 @@ repos:
         language: system
         entry: "./scripts/ci/pre_commit_mypy.sh"
         files: \.py$
-        exclude: ^airflow/_vendor/.*$
+        exclude: ^airflow/_vendor/.*$|^dev
 
 Review comment:
   ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430#discussion_r379896525
 
 

 ##########
 File path: scripts/ci/in_container/_in_container_script_init.sh
 ##########
 @@ -0,0 +1,31 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -euo pipefail
+
+# This should only be sourced from CI directory!
 
 Review comment:
   Resolved

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430#discussion_r379894057
 
 

 ##########
 File path: scripts/ci/ci_before_install.sh
 ##########
 @@ -15,25 +15,14 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-set -xeuo pipefail
+set -x
 
 MY_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 
-# shellcheck source=scripts/ci/_utils.sh
-. "${MY_DIR}/_utils.sh"
-
-basic_sanity_checks
-
-script_start
+# shellcheck source=scripts/ci/_script_init.sh
+. "${MY_DIR}/_script_init.sh"
 
 Review comment:
   What do you think of changing the pattern for how we import this new file to:
   
   ```suggestion
   . "$( dirname "${BASH_SOURCE[0]}" )/_script_init.sh"
   ```
   
   and then also setting `MY_DIR` in it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430#discussion_r379894194
 
 

 ##########
 File path: scripts/ci/ci_before_install.sh
 ##########
 @@ -15,25 +15,14 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-set -xeuo pipefail
+set -x
 
 MY_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 
-# shellcheck source=scripts/ci/_utils.sh
-. "${MY_DIR}/_utils.sh"
-
-basic_sanity_checks
-
-script_start
+# shellcheck source=scripts/ci/_script_init.sh
+. "${MY_DIR}/_script_init.sh"
 
 Review comment:
   Why not. Let me try :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430#discussion_r379898397
 
 

 ##########
 File path: scripts/ci/pre_commit_check_license.sh
 ##########
 @@ -15,9 +15,6 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-set -uo pipefail
 
 Review comment:
   Updated it to source the ci_scripts instead of running them - this way set -euo and exit on error will come from the _utils.sh

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430#discussion_r379898397
 
 

 ##########
 File path: scripts/ci/pre_commit_check_license.sh
 ##########
 @@ -15,9 +15,6 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-set -uo pipefail
 
 Review comment:
   Updated it to source the ci_scripts instead of running them - this way set -euo and exit on error will come from the _script_init.sh

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430#discussion_r379896917
 
 

 ##########
 File path: .pre-commit-config.yaml
 ##########
 @@ -285,14 +285,14 @@ repos:
         language: system
         entry: "./scripts/ci/pre_commit_mypy.sh"
         files: \.py$
-        exclude: ^airflow/_vendor/.*$
+        exclude: ^airflow/_vendor/.*$|^dev
 
 Review comment:
   Oh right. Was just wondering where this file/folder came from as I didn't see it in our repo anywhere.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430#discussion_r379896462
 
 

 ##########
 File path: scripts/ci/ci_before_install.sh
 ##########
 @@ -15,25 +15,14 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-set -xeuo pipefail
+set -x
 
 MY_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 
-# shellcheck source=scripts/ci/_utils.sh
-. "${MY_DIR}/_utils.sh"
-
-basic_sanity_checks
-
-script_start
+# shellcheck source=scripts/ci/_script_init.sh
+. "${MY_DIR}/_script_init.sh"
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7430: [AIRFLOW-6816] Simplified common functions in breeze scripts

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7430: [AIRFLOW-6816] Simplified common functions in breeze scripts
URL: https://github.com/apache/airflow/pull/7430#issuecomment-586736743
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7430?src=pr&el=h1) Report
   > Merging [#7430](https://codecov.io/gh/apache/airflow/pull/7430?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/cec9249f904bd91be9cb5a6be7e04979585da12e?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7430/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7430?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7430      +/-   ##
   ==========================================
   - Coverage   86.65%   86.36%   -0.29%     
   ==========================================
     Files         878      878              
     Lines       41168    41168              
   ==========================================
   - Hits        35675    35556     -119     
   - Misses       5493     5612     +119
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7430?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7430/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7430/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7430/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7430/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.38% <0%> (-25.52%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7430/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [airflow/bin/airflow](https://codecov.io/gh/apache/airflow/pull/7430/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vYWlyZmxvdw==) | `84.61% <0%> (ø)` | :arrow_up: |
   | [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/7430/diff?src=pr&el=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `86.95% <0%> (ø)` | :arrow_up: |
   | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7430/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
   | [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7430/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <0%> (ø)` | :arrow_up: |
   | [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7430/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100% <0%> (ø)` | :arrow_up: |
   | ... and [748 more](https://codecov.io/gh/apache/airflow/pull/7430/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7430?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7430?src=pr&el=footer). Last update [cec9249...806cc4e](https://codecov.io/gh/apache/airflow/pull/7430?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430#discussion_r379894614
 
 

 ##########
 File path: scripts/ci/pre_commit_check_license.sh
 ##########
 @@ -15,9 +15,6 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-set -uo pipefail
 
 Review comment:
   No ` set -euo pipefail ` here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430#discussion_r379896545
 
 

 ##########
 File path: scripts/ci/in_container/_in_container_utils.sh
 ##########
 @@ -15,9 +15,8 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
 #
-# Asserts that you are actually in container
+# Asserts that ou are actually in container
 
 Review comment:
   Removed the comment. it's superfluous

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7430: [AIRFLOW-6816] Simplified common functions in breeze scripts

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7430: [AIRFLOW-6816] Simplified common functions in breeze scripts
URL: https://github.com/apache/airflow/pull/7430#discussion_r379912446
 
 

 ##########
 File path: scripts/ci/ci_before_install.sh
 ##########
 @@ -15,25 +15,12 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+set -x
 
 Review comment:
   Debug or left in on purpose?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430#discussion_r379894225
 
 

 ##########
 File path: scripts/ci/in_container/_in_container_script_init.sh
 ##########
 @@ -0,0 +1,31 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -euo pipefail
+
+# This should only be sourced from CI directory!
 
 Review comment:
   ```suggestion
   # This should only be sourced from ci/in_container directory!
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430#discussion_r379894134
 
 

 ##########
 File path: .pre-commit-config.yaml
 ##########
 @@ -285,14 +285,14 @@ repos:
         language: system
         entry: "./scripts/ci/pre_commit_mypy.sh"
         files: \.py$
-        exclude: ^airflow/_vendor/.*$
+        exclude: ^airflow/_vendor/.*$|^dev
 
 Review comment:
   I found out that on linux when running pre-commit --all-files will fail without MOUNT_ALL_SOURCES (this is how it runs on Travis.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk merged pull request #7430: [AIRFLOW-6816] Simplified common functions in breeze scripts

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7430: [AIRFLOW-6816] Simplified common functions in breeze scripts
URL: https://github.com/apache/airflow/pull/7430
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7430: [AIRFLOW-6816] Separated out common utils
URL: https://github.com/apache/airflow/pull/7430#discussion_r379894240
 
 

 ##########
 File path: scripts/ci/in_container/_in_container_utils.sh
 ##########
 @@ -15,9 +15,8 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
 #
-# Asserts that you are actually in container
+# Asserts that ou are actually in container
 
 Review comment:
   ```suggestion
   # Asserts that you are actually in container
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services