[GitHub] [doris] zhannngchen commented on a diff in pull request #20762: [Enhancement](merge-on-write) optimize contains_agg when calculate delete bitmap

["zhannngchen (via GitHub)" <gi...@apache.org>]

zhannngchen commented on code in PR #20762:
URL: https://github.com/apache/doris/pull/20762#discussion_r1228897952


##########
be/src/olap/tablet_meta.cpp:
##########
@@ -941,6 +941,21 @@ bool DeleteBitmap::contains_agg(const BitmapKey& bmk, uint32_t row_id) const {
     return get_agg(bmk)->contains(row_id);
 }
 
+bool DeleteBitmap::contains_agg_without_cache(const BitmapKey& bmk, uint32_t row_id) const {
+    DeleteBitmap::BitmapKey start {std::get<0>(bmk), std::get<1>(bmk), 0};
+    for (auto it = delete_bitmap.lower_bound(start); it != delete_bitmap.end(); ++it) {

Review Comment:
   you should stop at the `bmk`, consider the version in `bmk`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org