You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/29 14:14:14 UTC
[GitHub] [iceberg-docs] samredai commented on a diff in pull request #131: Adding vendors page
samredai commented on code in PR #131:
URL: https://github.com/apache/iceberg-docs/pull/131#discussion_r933314031
##########
landing-page/content/common/vendors.md:
##########
@@ -0,0 +1,39 @@
+---
+title: "Vendors"
+url: vendors
+disableSidebar: true
+---
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+## Vendors shipping Apache Iceberg
Review Comment:
nit: "Vendors With Iceberg Table Support"? or maybe "Vendors Supporting Iceberg Tables"?
##########
docs/config.toml:
##########
@@ -34,9 +34,10 @@ home = [ "HTML", "RSS", "SearchIndex" ]
{ name = "Quickstart", url = "/spark-quickstart", weight = 100 },
{ name = "Docs", url = "/docs/latest", weight = 200 },
{ name = "Releases", pre = "relative", url = "../../releases", weight = 600 },
+ { name = "Roadmap", pre = "relative", url = "../../roadmap", weight = 997 },
{ name = "Blogs", pre = "relative", url = "../../blogs", weight = 998 },
{ name = "Talks", pre = "relative", url = "../../talks", weight = 999 },
- { name = "Roadmap", pre = "relative", url = "../../roadmap", weight = 997 },
+ { name = "Vendors", pre = "relative", url = "../../vendors", weight = 1000 },
Review Comment:
Does this need to be a topnav item? The home page has a lot of marketing content and buttons already so what if we add a blurb about vendors somewhere there and have a button that says "Vendor List" which takes you to vendors.md?
<img width="1626" alt="Screen Shot 2022-07-29 at 7 05 12 AM" src="https://user-images.githubusercontent.com/43911210/181777445-0012ba8a-1ad6-4958-a5f3-7f5c19486169.png">
##########
landing-page/content/common/vendors.md:
##########
@@ -0,0 +1,39 @@
+---
+title: "Vendors"
+url: vendors
+disableSidebar: true
+---
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+## Vendors shipping Apache Iceberg
+
+This page contains some of the vendors who are shipping Apache Iceberg in their products
+
+
+### [Cloudera](http://clouera.com)
+
+Cloudera Data Platform integrates Apache Iceberg to the following components:
Review Comment:
I like the content here! Later on we can put this in a shortcode that will add some custom styling and also make this more like a form to keep every new addition consistent. That way it's easier to just fill out name, link, description, feature-list, code-snippet, etc with character limits built into the styling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org