[jira] [Commented] (ZOOKEEPER-4216) Flaky test: WatcherCleanerTest.testDeadWatcherMetrics

["Damien Diederen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-4216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296631#comment-17296631 ] 

Damien Diederen commented on ZOOKEEPER-4216:
--------------------------------------------

Hi @maoling,

Thank you for these reports about flaky tests.  We have to fix/improve them, one by one, and having tickets is a first step.

I believe this one has been taken care of, however: I widened its window from 5s to 20s in ZOOKEEPER-4200, which was merged by Enrico on 2021-02-17—two days before this ticket was filed.  And looking at this:

{noformat}
AssertionFailedError: expected: <20.0> but was: <27.3333>
{noformat}

it looks like it would have succeeded with the new version.

Would you have a reference of the commit with which it happened?



> Flaky test: WatcherCleanerTest.testDeadWatcherMetrics
> -----------------------------------------------------
>
>                 Key: ZOOKEEPER-4216
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4216
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>            Reporter: Ling Mao
>            Priority: Minor
>             Fix For: 3.8.0
>
>
> {code:java}
> [INFO] Running org.apache.zookeeper.server.watch.WatchManagerTest
> [INFO] Running org.apache.zookeeper.server.watch.WatchManagerTest[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.836 s - in org.apache.zookeeper.server.PrepRequestProcessorMetricsTest
> [INFO] Running org.apache.zookeeper.server.ZooKeeperServerCreationTest
> [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5.26 s <<< FAILURE! - in org.apache.zookeeper.server.watch.WatcherCleanerTest[ERROR] testDeadWatcherMetrics  Time elapsed: 0.142 s  <<< FAILURE!org.opentest4j.AssertionFailedError: expected: <20.0> but was: <27.3333> at org.apache.zookeeper.server.watch.WatcherCleanerTest.testDeadWatcherMetrics(WatcherCleanerTest.java:166)
> [INFO] Running org.apache.zookeeper.server.InvalidSnapshotTest[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.196 s - in org.apache.zookeeper.server.ZooKeeperServerCreationTest[INFO] Tests run: 8, Failures: 0,
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)