[GitHub] [flink] wangyang0918 commented on issue #10532: [FLINK-15053][runtime] Escape all dynamical property values for taskmanager

[GitBox <gi...@apache.org>]

wangyang0918 commented on issue #10532: [FLINK-15053][runtime] Escape all dynamical property values for taskmanager
URL: https://github.com/apache/flink/pull/10532#issuecomment-570537923
 
 
   >>    For unix-like OS(Linux, MacOS, FREE_BSD, etc.), each value will put in single quotes. This works for all chars except single quote itself. To escape the single quote, close the quoting before it, insert the escaped single quote, and then re-open the quoting. For example, the value is my'value and the escaped value is 'my'\''value'.
   
   >>    For windows OS, each value will be surrounded with double quotes. The double quote itself needs to be escaped with back slash. Also the caret symbol need to be escaped with double carets since the window command uses it to escape characters.
   
   @tillrohrmann I have address your comments and have the following updates.
   * Add `WINDOWS_DOUBLE_QUOTE_ESCAPER` to escape value with double quotes
   * Add a test `testEscapeDynamicPropertyValueWithDoubleQuote`
   * Update `TaskManagerLoadingDynamicPropertiesITCase` to work on windows
   
   I have run the related tests on Mac/Windows/Linux, and they works well. Please take a look again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services