[GitHub] [hive] pgaref commented on a change in pull request #2004: HIVE-24037 Parallelize hash table constructions in map joins

[GitBox <gi...@apache.org>]

pgaref commented on a change in pull request #2004:
URL: https://github.com/apache/hive/pull/2004#discussion_r631127066



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinBytesTableContainer.java
##########
@@ -499,6 +500,13 @@ public void put(Writable currentKey, Writable currentValue) throws SerDeExceptio
     hashMap.put(directWriteHelper, -1);
   }
 
+  @Override public long calculateLongHashCode(BytesWritable currentKey)
+      throws HiveException, IOException, SerDeException {
+    directWriteHelper.setKeyValue(currentKey, null);
+    directWriteHelper.getHashFromKey();
+    return 0;

Review comment:
       Maybe return directWriteHelper.getHashFromKey()   ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org