[GitHub] [incubator-doris] morningman commented on a change in pull request #3051: Support sharding tablet_map_lock into more small map locks to make good performance for tablet manage task

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #3051: Support sharding tablet_map_lock into more small map locks to make good performance for tablet manage task
URL: https://github.com/apache/incubator-doris/pull/3051#discussion_r389238513
 
 

 ##########
 File path: be/src/olap/tablet_manager.cpp
 ##########
 @@ -172,24 +183,29 @@ OLAPStatus TabletManager::_add_tablet_to_map_unlocked(TTabletId tablet_id, Schem
     RETURN_NOT_OK_LOG(tablet->register_tablet_into_dir(), Substitute(
             "fail to register tablet into StorageEngine. data_dir=$0",
             tablet->data_dir()->path()));
-
-    _tablet_map[tablet_id].table_arr.push_back(tablet);
-    _tablet_map[tablet_id].table_arr.sort(_cmp_tablet_by_create_time);
-    _partition_tablet_map[tablet->partition_id()].insert(tablet->get_tablet_info());
+    tablet_map_t& tablet_map = _get_tablet_map(tablet_id);
+    tablet_map[tablet_id].table_arr.push_back(tablet);
+    tablet_map[tablet_id].table_arr.sort(_cmp_tablet_by_create_time);
+    {
+        ReadLock rlock(&_partition_tablet_map_lock);
+        _partition_tablet_map[tablet->partition_id()].insert(tablet->get_tablet_info());
 
 Review comment:
   This method name is `_add_tablet_to_map_unlocked()`, why you add a rlock here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org