You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/09/09 23:54:19 UTC

[Impala-ASF-CR] IMPALA-8932: shell shouldn't retry kerberos over http 

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14201


Change subject: IMPALA-8932: shell shouldn't retry kerberos over http
......................................................................

IMPALA-8932: shell shouldn't retry kerberos over http

Change-Id: I5dde277a6a0ddbe5a919bcf376bbc19f0b48e95e
---
M shell/impala_client.py
M shell/impala_shell.py
2 files changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/14201/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5dde277a6a0ddbe5a919bcf376bbc19f0b48e95e
Gerrit-Change-Number: 14201
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8932: shell shouldn't retry kerberos over http

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14201 )

Change subject: IMPALA-8932: shell shouldn't retry kerberos over http
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14201/1/shell/impala_client.py
File shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/14201/1/shell/impala_client.py@379
PS1, Line 379:     # TODO: if we enable this, need to re-enable the automatic kerberos retry logic
> nit: This comment reads somewhat of. Should it say "if we want to enable th
Rephrased a bit and referenced the JIRA



-- 
To view, visit http://gerrit.cloudera.org:8080/14201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dde277a6a0ddbe5a919bcf376bbc19f0b48e95e
Gerrit-Change-Number: 14201
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Sep 2019 00:19:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8932: shell shouldn't retry kerberos over http

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Lars Volker, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14201

to look at the new patch set (#2).

Change subject: IMPALA-8932: shell shouldn't retry kerberos over http
......................................................................

IMPALA-8932: shell shouldn't retry kerberos over http

Change-Id: I5dde277a6a0ddbe5a919bcf376bbc19f0b48e95e
---
M shell/impala_client.py
M shell/impala_shell.py
2 files changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/14201/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5dde277a6a0ddbe5a919bcf376bbc19f0b48e95e
Gerrit-Change-Number: 14201
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] IMPALA-8932: shell shouldn't retry kerberos over http

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14201 )

Change subject: IMPALA-8932: shell shouldn't retry kerberos over http
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4511/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dde277a6a0ddbe5a919bcf376bbc19f0b48e95e
Gerrit-Change-Number: 14201
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Sep 2019 00:35:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8932: shell shouldn't retry kerberos over http

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14201 )

Change subject: IMPALA-8932: shell shouldn't retry kerberos over http
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4915/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/14201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dde277a6a0ddbe5a919bcf376bbc19f0b48e95e
Gerrit-Change-Number: 14201
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Sep 2019 00:19:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8932: shell shouldn't retry kerberos over http

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14201 )

Change subject: IMPALA-8932: shell shouldn't retry kerberos over http
......................................................................

IMPALA-8932: shell shouldn't retry kerberos over http

Change-Id: I5dde277a6a0ddbe5a919bcf376bbc19f0b48e95e
Reviewed-on: http://gerrit.cloudera.org:8080/14201
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M shell/impala_client.py
M shell/impala_shell.py
2 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5dde277a6a0ddbe5a919bcf376bbc19f0b48e95e
Gerrit-Change-Number: 14201
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8932: shell shouldn't retry kerberos over http

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14201 )

Change subject: IMPALA-8932: shell shouldn't retry kerberos over http
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4512/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dde277a6a0ddbe5a919bcf376bbc19f0b48e95e
Gerrit-Change-Number: 14201
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Sep 2019 00:58:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8932: shell shouldn't retry kerberos over http

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14201 )

Change subject: IMPALA-8932: shell shouldn't retry kerberos over http
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dde277a6a0ddbe5a919bcf376bbc19f0b48e95e
Gerrit-Change-Number: 14201
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Sep 2019 04:25:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8932: shell shouldn't retry kerberos over http

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14201 )

Change subject: IMPALA-8932: shell shouldn't retry kerberos over http
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14201/1/shell/impala_client.py
File shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/14201/1/shell/impala_client.py@379
PS1, Line 379:     # TODO: if we enable this, need to re-enable the automatic kerberos retry logic
nit: This comment reads somewhat of. Should it say "if we want to enable this"? Maybe I'm just missing something.



-- 
To view, visit http://gerrit.cloudera.org:8080/14201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dde277a6a0ddbe5a919bcf376bbc19f0b48e95e
Gerrit-Change-Number: 14201
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Sep 2019 23:57:12 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8932: shell shouldn't retry kerberos over http

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14201 )

Change subject: IMPALA-8932: shell shouldn't retry kerberos over http
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dde277a6a0ddbe5a919bcf376bbc19f0b48e95e
Gerrit-Change-Number: 14201
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Sep 2019 23:57:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8932: shell shouldn't retry kerberos over http

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14201 )

Change subject: IMPALA-8932: shell shouldn't retry kerberos over http
......................................................................


Patch Set 2: Code-Review+2

carry the +2s


-- 
To view, visit http://gerrit.cloudera.org:8080/14201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dde277a6a0ddbe5a919bcf376bbc19f0b48e95e
Gerrit-Change-Number: 14201
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Sep 2019 00:19:24 +0000
Gerrit-HasComments: No