You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2016/11/23 21:52:13 UTC
[Impala-ASF-CR] IMPALA-4529: speed up parsing of identifiers
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5210
Change subject: IMPALA-4529: speed up parsing of identifiers
......................................................................
IMPALA-4529: speed up parsing of identifiers
Instead of using substring(), parseInt() and a try/catch, directly
check the character.
Change-Id: Iebef43a6a2f7923ca0e9c158d83f5c06f26da0cd
---
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
1 file changed, 1 insertion(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/5210/1
--
To view, visit http://gerrit.cloudera.org:8080/5210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iebef43a6a2f7923ca0e9c158d83f5c06f26da0cd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4529: speed up parsing of identifiers
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4529: speed up parsing of identifiers
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebef43a6a2f7923ca0e9c158d83f5c06f26da0cd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4529: speed up parsing of identifiers
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4529: speed up parsing of identifiers
......................................................................
Patch Set 1: Code-Review+2
nice
--
To view, visit http://gerrit.cloudera.org:8080/5210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebef43a6a2f7923ca0e9c158d83f5c06f26da0cd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4529: speed up parsing of identifiers
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4529: speed up parsing of identifiers
......................................................................
Patch Set 1: Verified-1
Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/548/
--
To view, visit http://gerrit.cloudera.org:8080/5210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebef43a6a2f7923ca0e9c158d83f5c06f26da0cd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4529: speed up parsing of identifiers
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4529: speed up parsing of identifiers
......................................................................
IMPALA-4529: speed up parsing of identifiers
Instead of using substring(), parseInt() and a try/catch, directly
check the character.
Change-Id: Iebef43a6a2f7923ca0e9c158d83f5c06f26da0cd
Reviewed-on: http://gerrit.cloudera.org:8080/5210
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Internal Jenkins
---
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
1 file changed, 1 insertion(+), 6 deletions(-)
Approvals:
Internal Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebef43a6a2f7923ca0e9c158d83f5c06f26da0cd
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins