You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/13 00:45:11 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36844: Update ExecutorClassLoader.scala

HyukjinKwon commented on code in PR #36844:
URL: https://github.com/apache/spark/pull/36844#discussion_r895257421


##########
repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala:
##########
@@ -54,7 +54,7 @@ class ExecutorClassLoader(
     classUri: String,
     parent: ClassLoader,
     userClassPathFirst: Boolean) extends ClassLoader(null) with Logging {
-  val uri = new URI(classUri)

Review Comment:
   @guolianwei plase
   
   1. file a JIRA
   2. describe how you reproduced the issue and tested this patch
   3. add a unit test.
   
   See also https://spark.apache.org/contributing.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org