You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/03 22:54:47 UTC

[GitHub] [camel] mcollovati opened a new pull request #4560: [CAMEL-15805] Prefix coverage directory with project base dir

mcollovati opened a new pull request #4560:
URL: https://github.com/apache/camel/pull/4560


   Launching route-coverage goal from root directory of a multi module
   project does not work because the directory passed to
   RouteCoverageHelper.parseDumpRouteCoverageByRouteId
   missed project base directory.
   This change adds project base directory to the relative path
   of route coverage data.
   
   - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   - [x] Each commit in the pull request should have a meaningful subject line and body.
   - [x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/master/CONTRIBUTING.md


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus merged pull request #4560: [CAMEL-15805] Prefix coverage directory with project base dir

Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4560:
URL: https://github.com/apache/camel/pull/4560


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] mcollovati commented on pull request #4560: [CAMEL-15805] Prefix coverage directory with project base dir

Posted by GitBox <gi...@apache.org>.
mcollovati commented on pull request #4560:
URL: https://github.com/apache/camel/pull/4560#issuecomment-721417455


   I did not found tests for camel-report-maven-plugin.
   Let me know if I should write an integration test based on maven-invoker-plugin for this change


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org