You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/23 14:44:51 UTC
[GitHub] [flink] zentol opened a new pull request #10933:
[FLINK-15651][tests] Refactor JarHandlerTest
zentol opened a new pull request #10933: [FLINK-15651][tests] Refactor JarHandlerTest
URL: https://github.com/apache/flink/pull/10933
Refactors the JarHandlerTest to test directly against the handlers instead of firing up an entire cluster.
- reuse handler setup from `JarSubmissionITCase`
- removed the jar creation within the test since it fails on windows
- added additional assertion that an exception is thrown
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10933: [FLINK-15651][tests]
Refactor JarHandlerTest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10933: [FLINK-15651][tests] Refactor JarHandlerTest
URL: https://github.com/apache/flink/pull/10933#issuecomment-577714366
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d4f96c8adca468e957e724a22344da42501c5f85 (Thu Jan 23 14:50:43 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10933: [FLINK-15651][tests]
Refactor JarHandlerTest
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10933: [FLINK-15651][tests] Refactor JarHandlerTest
URL: https://github.com/apache/flink/pull/10933#issuecomment-577727666
<!--
Meta data
Hash:d4f96c8adca468e957e724a22344da42501c5f85 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d4f96c8adca468e957e724a22344da42501c5f85
-->
## CI report:
* d4f96c8adca468e957e724a22344da42501c5f85 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10933:
[FLINK-15651][tests] Refactor JarHandlerTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10933: [FLINK-15651][tests] Refactor JarHandlerTest
URL: https://github.com/apache/flink/pull/10933#issuecomment-577727666
<!--
Meta data
Hash:d4f96c8adca468e957e724a22344da42501c5f85 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4582 TriggerType:PUSH TriggerID:d4f96c8adca468e957e724a22344da42501c5f85
Hash:d4f96c8adca468e957e724a22344da42501c5f85 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145779707 TriggerType:PUSH TriggerID:d4f96c8adca468e957e724a22344da42501c5f85
-->
## CI report:
* d4f96c8adca468e957e724a22344da42501c5f85 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145779707) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4582)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #10933: [FLINK-15651][tests]
Refactor JarHandlerTest
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #10933: [FLINK-15651][tests] Refactor JarHandlerTest
URL: https://github.com/apache/flink/pull/10933
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10933:
[FLINK-15651][tests] Refactor JarHandlerTest
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10933: [FLINK-15651][tests] Refactor JarHandlerTest
URL: https://github.com/apache/flink/pull/10933#issuecomment-577727666
<!--
Meta data
Hash:d4f96c8adca468e957e724a22344da42501c5f85 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4582 TriggerType:PUSH TriggerID:d4f96c8adca468e957e724a22344da42501c5f85
Hash:d4f96c8adca468e957e724a22344da42501c5f85 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145779707 TriggerType:PUSH TriggerID:d4f96c8adca468e957e724a22344da42501c5f85
-->
## CI report:
* d4f96c8adca468e957e724a22344da42501c5f85 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145779707) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4582)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services